Similar to #2744089: Fix visibility of AssertLegacyTrait::assertLink() we need to fix the visibility of the mentioned method.

I'll attach a small patch for it. OG is failing on travis CI with the message

PHP Fatal error: Access level to Drupal\simpletest\AssertContentTrait::assertNoEscaped() must be public (as in class Drupal\Tests\BrowserTestBase) in /home/travis/build/amitaibu/og/og_ui/tests/src/Functional/BundleFormAlterTest.php on line 167

CommentFileSizeAuthor
#4 2751711.patch670 bytesroysegall

Comments

RoySegall created an issue. See original summary.

roysegall’s picture

roysegall commented
Issue summary: View changes
roysegall’s picture

roysegall commented
Issue summary: View changes
roysegall’s picture

roysegall commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2751711.patch670 bytes
dawehner’s picture

dawehner
Primary language German
commented

Well, the other patch moves from public to protected, this from protected to public. There is some symmetry which is broken.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

I had encountered the same failure in OG today. I didn't realize this was already reported, I created a duplicate issue (with exactly the same title as this one, funnily enough :) - #2752315: Fix visibility of AssertLegacyTrait::assertNoEscaped().

In my patch the visibility is inverted to this patch: it changes from public to protected to be consistent with the other assertions. So I guess I'll leave mine up even though it is newer.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Closed (duplicate)