[D7] Simple Notify

There already exists a number of Notify modules for Drupal. See, for example: https://groups.drupal.org/node/15928

However, duplication of functionality is allowed, but our users need to be informed about possible functional overlap. This should be made is section with the heading "Similar projects and how they are different" on the project's project page that:

• acknowledges the existence of similar projects; and
• briefly explain how they are different.

Please take a look at the project page template and consider adding the section "Similar projects and how they are different".

Hello,
I`ve reviewed your module, there are some issues:
1) Readme file is not correct . Please, make it according specifications. https://www.drupal.org/node/2181737
2) You don't have hook_help. Please check it. https://www.drupal.org/node/1095546
3) I think there is better to use TRUE and FALSE instead of 0,1 and in all other cases http://storage6.static.itmages.com/i/16/0617/h_1466171044_3679783_a6ba5d...
Kind Regards.

Also I couldnt download project via link in description. Please check it.

Hi dropdiver,

Automatic Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxdrupallino2750595git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Not Follows the guidelines for in-project documentation and/or the README Template.
Please refer to this link https://www.drupal.org/node/2181737 for README Template
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
(*) 1. when i click on configuration then it gives error on http://local.d7.dev/admin/config page.
Fatal error: Call to undefined function simple_notify_get_subscriptons() in /Users/yogeshpawar/Sites/drupal-seven-dev/sites/all/modules/simple_notify/simple_notify.module on line 316

2. when "admin/config/simple-notifier" url checked on browser mentioned in hook_menu simple_notify.module then i got this new error Fatal error: require_once(): Failed opening required '/Users/yogeshpawar/Sites/drupal-seven-dev/sites/all/modules/simple_notify/admin/simple_notifiy.admin.inc' (include_path='.:/Applications/MAMP/bin/php/php5.6.10/lib/php') in /Users/yogeshpawar/Sites/drupal-seven-dev/includes/menu.inc on line 525

(+) 1. It would be good, if you implement hook_help in your module.

2. I couldnt clone project via link in description, when i change the url from git clone --branch 7.x-1.x drupallino@git.drupal.org:sandbox/drupallino/2750595.git to git clone --branch 7.x-1.x https://git.drupal.org:sandbox/drupallino/2750595.git then project gets cloned on my machine.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi dropdiver,

I reviewed your module. one big issue for creating that fatal errors is the misspelling of simple_notify to simple_notifiy.
please correct that mistake in .module, /includes/simple_notify.token.inc, .install files. hopefully this will remove all fatal errors in the module.

Documentation

The current project page has a section with the heading "Watcher". This is just one of the similar projects and there is no guidance about why this project is suffisciently different from other projects to not cause module duplication and/or fragmentation.

It looks like this projects duplicates various aspects of several other modules. I am aware of the following:

• Message notify
• Node notify
• Notifications
• Notify
• Subscriptions
• Watcher

Our users need to be informed about possible functional overlap with other modules. This should be made is section with the heading "Similar projects and how they are different" on the project's project page that:

1. acknowledges the existence of similar projects; and
2. explain how they are different.

Please take a look at the project page template and add the section "Similar projects and how they are different" to the project page.

Yogesh Pawar,
please do not change priority without giving a valid reason for doing it. I've reset it to "Normal". The misspelling you point out is not a valid reason.

Please ses this page for correct use of the priority field in the PAreview issue queue.

I am also surprised to find that you think that this project: "Does not cause module duplication and/or fragmentation", so I've spelled out my view on this topic in #15.

HI gisle,

Sorry for changing the priority of the project to major. will remember this thing in future.
also appolgies for the module duplication criteria. i have missed that point because i am new to project reviews.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.