Hello, thanks for your work on the module!

It would be great to be able to render the Google Map in grayscale.

CommentFileSizeAuthor
#2 allow_the_google_map_to-2746731-2.patch1.6 KBdinarcon

Comments

dinarcon created an issue. See original summary.

dinarcon’s picture

dinarcon commented
Status: Active » Needs review
StatusFileSize
new allow_the_google_map_to-2746731-2.patch1.6 KB

I have created a patch the modifies that GeolocationGoogleMapFormatter to allow the Google Map to be displayed in grayscale. This makes use of Styled Maps as described in https://developers.google.com/maps/documentation/javascript/styling

Note that the new type definition only specifies the saturation value which produce the grayscale effect. The code can be further extended to implement more features of the Google Maps API and make them configurable.

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

Works great! Allows Google Maps to fit in with any theme.

christianadamski’s picture

christianadamski commented
Status: Reviewed & tested by the community » Needs work
Related issues: +#2734643: Support Google Styled Maps (via Google API)

Help me out here for a second. I'm not very familiar with custom styles in Google Maps.

When I look at this issue: https://www.drupal.org/node/2734643

Is this kinda the same thing? Could these issues be joined? What would be the ideal result here?

christianadamski’s picture

christianadamski commented
Related issues: +#2747251: Merge Google Maps handling in Single Field Formatter and Common Map
christianadamski’s picture

christianadamski commented

Please see the referenced issue for a patch version against current git that integrates Google Map styles. It does so, by settings the "styles" option, not by adding a new MapStyle. One could add that as an additional optional feature.

christianadamski’s picture

christianadamski commented
Status: Needs work » Postponed (maintainer needs more info)

I just comitted the referenced issue. You can now add a style array for each map. However, they do not show up as separate styles, there are used as default on the specific map.

Do you actually want separate styles? Is that possible right now? If that is a common usecase not achievable right now, I would imagine a site wide management of styles.

christianadamski’s picture

christianadamski commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing for lack of activity