Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It'd be great if this module could support styling of google maps using their API as documented at https://developers.google.com/maps/documentation/javascript/styling It would then allow for support for things like SnazzyMaps (https://snazzymaps.com/).
I've created a small patch to do this. Currently it only works on Views maps, but could probably be extended for the rendered field view too.
Comment | File | Size | Author |
---|---|---|---|
#13 | 2734643-13-styled_maps.patch | 4.24 KB | kae76 |
geolocation_styled_maps.patch | 3.41 KB | stella | |
Comments
Comment #2
stella CreditAttribution: stella at Annertech for Glanbia commentedComment #3
screon CreditAttribution: screon commentedI need the same kind of functionality. I'll try out your patch somewhere this week and let you know if it works.
Comment #4
screon CreditAttribution: screon commentedJust tested your patch, and the feature working great! I was able to paste a JSON from Snazzymaps, and it successfully themed my map.However, the patch didn't apply to the latest dev version, there are some conflicts in the files which should be fixed..
Some remarks on my part after a (very) quick review:
Comment #9
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commented@stella testbot had some issues and some other stuff was committed.
Long story short: could you re-roll your patch against current git?
Comment #11
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedProbably related? https://www.drupal.org/node/2746731
Comment #12
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedComment #13
kae76 CreditAttribution: kae76 at Open Code Limited for Annertech commentedRe-rolled patch against current dev
Comment #14
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedComment #15
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedPlease see the referenced issue for a patch against current git. It builds the styles integration based on this patch. It extends the validation by checking for correct JSON. Interestingly enough, JSON demands all properties in "" which the Google style example do not adhere to.
If possible, please provide feedback.
Comment #16
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedI comitted #2747251 - I added both your usernames to the commit. I'm new to this, hopefully they show up in your commit history. If not ping me and I'll figure it out.
Comment #17
stella CreditAttribution: stella at Annertech for Glanbia commentedExcellent, thanks!
Comment #18
kae76 CreditAttribution: kae76 at Open Code Limited for Annertech commentedOnly just seen this, thank you :)
Comment #19
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedHmm, this is the commit: https://www.drupal.org/commitlog/commit/5688/67b9b8154c2bad4c4bdc67360cb...
I followed this guide: https://www.drupal.org/node/52287
And you both still do not show up as comitters. I don't know what I missed. Any ideas?
Comment #20
derjochenmeyer CreditAttribution: derjochenmeyer at forward-media.de commentedChristian, it seems the git message is for git credit only? For Drupal.org credit you maybe need to use the Credit & committing UI below the issue.
Commit messages - providing history and credit
Comment #21
ChristianAdamski CreditAttribution: ChristianAdamski as a volunteer commentedOk, I added both names as getting credit in the other issue, and I see that does show up in the profiles each. I have now idea how to add people as committers and asking in #drupal-contribute did not result in any new insights. So I guess this is the best I can do...
It would be really good to be able to add other people as co-committers as well.
Comment #22
derjochenmeyer CreditAttribution: derjochenmeyer at forward-media.de commentedHm... don't know if i understand what you mean with co-committers. I think there has to be ONE author/committer per patch/commit in git.