Closed (fixed)
Project:
Geolocation Field
Version:
8.x-1.x-dev
Component:
Geolocation field
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jun 2016 at 15:23 UTC
Updated:
7 Jul 2016 at 09:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
christianadamski commentedOn a more general level, one could of course ask the question, whether geolocation field should bother to handle Google maps in the first place. Something like https://www.drupal.org/project/gmap might be more suited. But I don't see them or any alternative around the corner, so I guess that sticks with us for now.
Comment #3
christianadamski commentedv1 - Form handling merged in a new trait.
Comment #4
christianadamski commentedComment #5
christianadamski commentedThis patch does a number of things:
- fixes some more eslint warnings
- moves JS closer to Drupal standards (camelCase, use Drupal prefix, more documentation)
- lets the commonMap handler run of the geolocation core JS instead of reproducing its functionality
- all of the above patch, which is
-- introduce new googleMapsTrait
-- fetch and process settings in that trait
-- let the field formatter and views style use said trait
Comment #6
christianadamski commentedAnd here's the final thing with Google map styles added.
Comment #8
christianadamski commentedComment #11
christianadamski commented