Some modules Display Suite and Pathologic both do not remove filter configuration upon uninstall. With this in mind Drupal 7 doesn't show these filter configuration settings for those modules... but it still exists in the database.

Consider adding some logic that will only pull filters from modules that are enabled.

CommentFileSizeAuthor
#16 Screenshot 2019-11-19 at 12.08.07.png498.89 KBwim leers
#16 Screenshot 2019-11-19 at 12.07.59.png500.8 KBwim leers
#9 filter-remove_filters_from_uninstalled_modules-2734475-9-D8.patch1.12 KBgaurav.kapoor
#2 filter-remove_filters_from_uninstalled_modules-2734475-2-D8.patch1.13 KBgeneralredneck

Comments

generalredneck created an issue. See original summary.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
StatusFileSize
new filter-remove_filters_from_uninstalled_modules-2734475-2-D8.patch1.13 KB
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Active » Needs review

Forgot to update status

Status: Needs review » Needs work

The last submitted patch, 2: filter-remove_filters_from_uninstalled_modules-2734475-2-D8.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

imiksu’s picture

imiksu
Location Finland
commented
Issue tags: +DCampBaltics

We'll try to investigate why tests failed.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Needs tests

This needs some testing added.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review
StatusFileSize
new filter-remove_filters_from_uninstalled_modules-2734475-9-D8.patch1.12 KB

Re-rolled for D8.4 and added short array syntax.

Status: Needs review » Needs work

The last submitted patch, 9: filter-remove_filters_from_uninstalled_modules-2734475-9-D8.patch, failed testing.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

quietone’s picture

quietone commented
Issue tags: +migrate-d7-d8
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3061571: If no Drupal 8 equivalent filter is found during migration, drop transformation-only filters, so that body fields show up

AFAICT this would also help prevent the problem of many D7 databases having the php_code filter still in some of its text formats (perhaps dating back to the D5/D6 days), which then causes all sorts of problems as described in #3061571: If no Drupal 8 equivalent filter is found during migration, drop transformation-only filters, so that body fields show up.

EDIT: hm, less sure about this now… see next comment.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
Issue summary: View changes
StatusFileSize
new Screenshot 2019-11-19 at 12.07.59.png500.8 KB
new Screenshot 2019-11-19 at 12.08.07.png498.89 KB

Actually, on my own site, this is what I see.

The php_code filter is present on half a dozen formats, but is disabled on all but one, meaning it won't cause migration issues
The only format for which it's still enabled had PHP code as its only purpose

The problem still exists though, but only on Drupal 7 sites which were "relatively poorly" managed (to be fair, it's silly that Drupal 7 didn't take care of this automatically).

Demoting to Minor because I think this only affects a small fraction of D7 sites. But it definitely would improve reliability of migrations.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Version: 9.5.x-dev » 11.x-dev
quietone’s picture

quietone commented
Status: Needs work » Postponed

https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

quietone’s picture

quietone commented
Status: Postponed » Closed (won't fix)

The Migrate Drupal and Migrate Drupal UI modules are deprecated and will be removed from Drupal 12. For these modules, effort is now focused on bug fixes and necessary tasks. Therefore, this feature request is closed as won't fix.

Thanks to all for working on this!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.