It would be nice to have a checkbox in FieldFormatter's settings form for "Display download link below player", and when it's enabled, a link with the file's name would be displayed as a link below the player.

CommentFileSizeAuthor
#5 audiofield-optional_download_link-2733723-5.patch7.1 KBboobaa
#3 audiofield-optional_download_link-2733723-3.patch2.33 KBboobaa

Comments

Boobaa created an issue. See original summary.

boobaa’s picture

boobaa
he/him
commented
Parent issue: » #2706005: D8 match feature parity with D7 [Meta]
boobaa’s picture

boobaa
he/him
commented
Status: Active » Needs review
StatusFileSize
new audiofield-optional_download_link-2733723-3.patch2.33 KB

Attached is a working solution for this.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented

Shouldn't link generator service be used here ?

boobaa’s picture

boobaa
he/him
commented
StatusFileSize
new audiofield-optional_download_link-2733723-5.patch7.1 KB

Rerolled the patch against 8.x-1.1. Why should the link generator service be used here?

  • Daniel.Moberly committed bb01c5f on 8.x-1.x 
    Issue #2733723 by Daniel.Moberly, Boobaa: Optionally include download...
daniel.moberly’s picture

daniel.moberly commented
Status: Needs review » Fixed

Committed the patch with some significant changes to rendering to make it compatible as well as some changes to the general class structure to make the rendering simpler. Should be available in the next release. Thanks Boobaa for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.