Closed (fixed)
Project:
Search API
Version:
8.x-1.x-dev
Component:
Plugins
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 May 2016 at 23:22 UTC
Updated:
2 Aug 2016 at 13:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
larowlandamn D8 is frickin nice
Comment #5
larowlanNow with tests
Comment #6
larowlanfix typo
better engrish++
Comment #9
larowlandoh, do you even --relative @larowlan
Comment #10
borisson_Oh wow, that does look very easy, thanks!
Comment #11
drunken monkeyGreat job, thanks a lot!
It looks so easy when someone knows what they're doing …
This needed a re-roll, though. Also, while it's awesome that you included proper DI, we normally also add getters that automatically default to using
\Drupalfor the injected properties. At least for consistency's sake.Finally: is there maybe an easy way to verify in the tests that the theme is indeed being switched? Either through the output or by trying to catch the code at some point while it's in the other theme? That would of course be great to avoid regressions later.
But we can also skip it if it's too much trouble.
In any case, again, thanks a lot!
Comment #12
drunken monkeyRe-roll, plus a tests-only patch to see whether the existing test doesn't suffice after all. (The comment suggests as much, at least.)
Comment #14
borisson_Comment #16
drunken monkeyAwesome!
Thanks also, Joris, for reviewing!
Committed.
Thanks a lot again, Lee, for providing the solution!