Files in question:
http://cgit.drupalcode.org/yoast_seo/tree/js/lib/yoast/yoast-seo.min.js?...
http://cgit.drupalcode.org/yoast_seo/tree/js/js-text-analysis/yoast-seo....

Note that this file includes an external JS library from https://github.com/SlexAxton/Jed/blob/master/jed.js.

From 3rd party libraries and content on Drupal.org:

This is the policy for 3rd party code libraries in Drupal's contribution repositories.

In general 3rd party libraries are forbidden, so do not commit any. Instead, document for your users how to find and install the library themselves.

Exceptions can be made if the 3rd party library:

1. had to be modified to work with Drupal, and the modifications were not accepted by the original author;
2. is generally difficult to find, or the specific version needed is hard to find;
3. is no longer maintained by the original author.

Any of the above exceptions needs approval by Drupal Licensing Working Group (LWG). Exception requests should be posted in the LWG's issue queue with the component "Exception Request". (Upfront: 90% of all exception requests are moot. Only ask for an exception if it is really required.)

Neither of these three exception seem to apply. Could you please clarify if any of these exceptions apply?

Please see https://www.drupal.org/git-repository-usage-policy.

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Licensing issue including external library » External library included without exception approval from the Licensing Working Group
Issue tags: -license issues
kingdutch’s picture

kingdutch
he/him
Primary language English
commented

A request for this has been made at #2873002: Exception request for YoastSEO.js in Real-Time SEO module

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Active » Needs work

This has been fixed in the work that is being done in preparation for creating version 8.x-2.x. The groundwork has been done and an adapted version of the library will be pulled in through composer in future versions.

Will mark this for review once the first development release of 2.x is out.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

  • Kingdutch committed 951bb40 on 8.x-2.x 
    Issue #2726871 by Kingdutch: External library included without exception...
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Needs work » Needs review

This needs review on the 2.x branch.

szeidler’s picture

szeidler commented

I can confirm, that the external library is not included in the 2.x branch anymore and will be invoked via an defined library. So in sense of the issue it is fixed.

But it seems, that there is something wrong with the library definition. When I'm downloading the specified 1.2.2 release, there is no /libraries/YoastSEO.js/dist folder. So basically it's not working at all.

Should it be handled in a separate issue?

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Assigned: Unassigned » kingdutch
Status: Needs review » Needs work

Thanks for testing this szeidler. The version that 2.x is developing against is currently a later version of the library. Newer versions of the YoastSEO.js library don't have a distribution anymore so its manually compiled.

I see I haven't updated the external library so the version needed for 2.x is still on the branch https://github.com/goalgorilla/YoastSEO.js/tree/split-editing

I'll see if I can clean this up and move it into master with a proper tag.

  • Kingdutch committed 09c6d7d on 8.x-2.x 
    Issue #2726871 by Kingdutch: External library included without exception...
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Assigned: kingdutch » Unassigned
Status: Needs work » Needs review
Issue tags: +Needs documentation

Our implementation of the library has been published on Packagist and added to the composer.json

This means it can now properly be installed with composer.

The documentation will need to be updated to reflect that for manual installation this package should be downloaded and placed in the libraries folder.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Parent issue: » #2879061: [meta] Roadmap for version 8.x-2.0 of the Real-time SEO module
kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Needs review » Fixed

This seems to have been working for quite some time without any complaints so I'm marking this as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.