The tests included in the commit of #2641392: Review our language/translation support are not sufficient.
The tests all pass for the Solr backend but search_api_solr doesn't handle these languages at all. See #2725783: Solr backend misses language filter.
The tests should have discovered that. The problem is that the tests themselves do the convertion. See http://cgit.drupalcode.org/search_api/diff/tests/src/Kernel/BackendTestB...
BTW it's a good decision to leave the convertion of the language parameters into a condition to the backend. That eases the process for search_api_solr_multilingual.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2725791-3--properly_test_backend_language_support.patch | 1.41 KB | drunken monkey |
| #3 | 2725791-3--properly_test_backend_language_support--tests_only.patch | 2.98 KB | drunken monkey |
Comments
Comment #2
mkalkbrennerComment #3
drunken monkeyYou're right, that doesn't actually do anything.
Patch attached.
Comment #6
borisson_I don't really understand these changes, but everything passes and if @mkalkbrenner agrees, this can go in. Anyway, I think I can set this to RTBC.
Comment #8
drunken monkeyIt's just about adding test cases/assertions that actually fail if the backend ignores the query's language settings. That wasn't the case before.
Anyways, thanks for reviewing! Committed.