Remove entity_load* usage for entity_view_display entity type

I'm at DrupalCon NOLA and am taking at look at this

After applying the patch there is one more instance of using functional loading.

core/modules/image/src/Entity/ImageStyle.php:140:      foreach (entity_load_multiple('entity_view_display') as $display) {

EntityViewDisplay::loadMultiple() can be used to load multiple entities.

Done.

Updated summary.

The following is missing from the top of core/modules/image/src/Entity/ImageStyle.php

use Drupal\Core\Entity\Entity\EntityViewDisplay;

That should fix the errors from the testbot as it states where to find the EntityViewDisplay class.

I missed it.

After applying the patch from #10 there are no more calls to entity_load() for entity_view_display entity types. The patch only addresses problems with this issue.

Unable to apply Patch. Patch re-roll needed.

I am working on patch re-roll.

Adding Rerolled Patch.

After applying the rerolled patch in #15 there are no more calls to entity_load*().

The reroll and the original patch have the same number of files changed, insertions, and deletions, so nothing extra was added in the reroll process.

Committed 6b70606 and pushed to 8.2.x. Thanks!

I think this causes an exception on PG during tests...
Please see PG testrunner

[18-May-2016 19:09:15 Australia/Sydney] Uncaught PHP Exception Drupal\Core\Database\DatabaseExceptionWrapper: "SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for integer: "number"

Let's see, queued for PG testing...

@valthebald right, actually it seems that the fails are caused by #1266748: Changing cardinality lower than highest existing delta causes data loss upon save instead. The failing test is ManageFieldsTest not ManageDisplayTest, my bad ;) Will leave a note over there...