A lot of work has gone into the 7.x version recently - including integrating with Facebook's SDK and API. Since the immediate need was for D7, this was not added to the 8.x version, and as a result none of that work is available for D8. Additionally, new contributors must work with an older version of Drupal.
- Update the 8.x version to have parity with 7.x.
- Afterwards change the contribution guidelines so that new features and bug fixes should be done on 8.x, and then backported to 7.x.
- Agree on which branch to use (jump to 8.x-2.x. See #2723617: Make 8.x-2.x-dev snapshot).
- Agree on approach
- Move page alter hook into base module
- Move config form into Base module & get Base module config form to parity with 7.x base form
- Add Base module classes
- Add submodules (high level tasks)
1. Display module
2. API module
3. API Rules module
(do not port RSS module)
- Resolve different approaches to Views submodule, between existing 8.x-1.x and 7.x-2.x.
- #2730699: Create CONTRIBUTING.md file
- Include an update to the GitHub CONTRIBUTION file (changes made upstream to 8.x, then backported to 7.x).
- Update the project homepage to reflect the above changes.
All the changes from 7.x (possibly apart from Views - but this is dependent on the TBD agreement above).
New API added from 7.x.
All the changes from 7.x (possibly apart from Views - but this is dependent on the TBD agreement above).
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | many-months-later.jpg | 20.66 KB | scottrigby |
Comments
Comment #2
scottrigbyMatt and I are working on this at DrupalCon right now.
Comment #3
scottrigbyComment #4
m4oliveiFinished with "Move page alter hook into base module". Merged to 2722613_8x_parity_with_7x branch. Updated description.
Comment #5
markdorisonComment #6
steffenrIs there any progress on porting the D7 version features to D8? I could not find any new branch / PRs on github. Right now we are planning / creating tickets for a relaunch of a larger site here at Burda. Hopefully i can get some project-time to port the already existing features to D8. But first i have to talk to my PM - maybe a part of the thunder.org team will help me porting the functionalities.
Comment #7
scottrigby@SteffenR I replied a bit in the FB dev group chat, but to this question above – the work so far is in the 2722613_8x_parity_with_7x branch on GitHub. Our thinking was that we'd triage on that branch before opening a PR against the new 8.x-2.x branch.
It'd be great to split up the tasks above – and we can go ahead and do that anytime in separate child issues after we merge this initial branch into 8.x-2.x as a starting point. But the task above that would be the most helpful to meet about and discuss is `Resolve different approaches to Views submodule, between existing 8.x-1.x and 7.x-2.x.`.
Let's coordinate in the FB chat about a time to meet up and discuss :)
Comment #8
steffenrHi Scott - great to see, that you already started building parity with D7. Next week i'll have to talk to my pm about their plans giving some project time in porting the whole D7 module to D8.
Comment #9
scottrigbyFinaly getting back to this. So this issue should really be broken out into separate sub-issues, focusing on the highest-priority tasks (see Remaining tasks above), so we don't get lost in minutia.
Comment #10
geek-merlinRRRReally great work!
Comment #11
scottrigbyUPDATE: Is anyone in this thread planning to be at DrupalCon Baltimore? @m4olivei and I are planning a BoF to try to resolve this issue (it will probably start with splitting up into sub-issues… which can be done in advance if anyone wants to help tackle that). Then this can become a master issue that links the new ones as child issues. If so, let us know we can find a good way to all connect.
Comment #12
m4oliveiI'm going to go ahead and take a crack at standing up sub-issues, and then turn this into a master issue.
Comment #13
m4oliveiOK, I quickly added all the sub-tasks that I teased out during a recent LOE discovery I did to port the module to D8. I tagged each by the sub-module name to which it's applicable.
https://www.drupal.org/project/issues/fb_instant_articles?categories=2&v...
Most interesting to me at least is:
https://www.drupal.org/node/2871637
Which is currently the only task I have for fb_instant_articles_display sub-module. I never liked the way that the D7 version was architected to hijack the render system, which was never really intended to output alternate formats. Let's discuss.
See you at DrupalCon!
Comment #15
m4oliveiWe can call this issue done. The 8.x-2.x branch now has feature parity, with the exception of rules/actions integration, but there is an alternative in place for that.
Further work on 8.x-2.x should get created as new issues. Look out for a release shortly!
Comment #16
m4oliveiComment #17
scottrigby@m4olivei Really psyched by all your hard work on this leg of the port! Wish I could have joined this part but so excellent.
Can you update the list at the top of this issue? It looks like all items in the list are complete except:
Maybe we should split those out into their own separate task issues?
Congrats. SO great.
Comment #18
m4oliveiThanks Scott!
Nah we can do them here. The project page has been updated, in addition to fully fleshed out documentation for the 8.x-2.x version here:
https://www.drupal.org/docs/8/modules/facebook-instant-articles
I can update the GitHub CONTRIBUTION file.
Comment #19
m4oliveiUpdated CONTRIBUTING.md file. Also updated description to reflect the items that have been done. I removed the one about the view module, we ended up carrying it forward in the D8 port. The implementation changed drastically and it made sense to keep it.