The make file tries to download the libraries required for this module. It was causing our site's make file to break the build script we run. Removing libraries from the module's make file, and adding the libraries through our make file, fixes this issue for us.

CommentFileSizeAuthor
views_pdf-remove-libraries-make.patch681 bytescdykstra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cdykstra created an issue. See original summary.

cdykstra’s picture

cdykstra CreditAttribution: cdykstra commented
Issue summary: View changes
cdykstra’s picture

cdykstra CreditAttribution: cdykstra commented
Issue summary: View changes
killua99’s picture

killua99 CreditAttribution: killua99 commented
Component: Code » Documentation
Category: Bug report » Support request
Status: Active » Postponed (maintainer needs more info)

Sorry, that's not possible neither the solution the library need to be in this make file it's the right way to do it. Please see more description to your problem.

The library for now will stay on the make file.

cdykstra’s picture

cdykstra CreditAttribution: cdykstra commented

Sure, but perhaps the project page should note that while these libraries are dependancies, TCPDF Version 5 or greater and FPDI are included in the module.

The instructions should be updated as well where it currently reads:

Installation

Installation instructions:

  1. Download the module or checkout the module.
  2. Upload the module to your Drupal instance.
  3. Download the required libraries. Download TCPDF and FPDI.
  4. Recomended versions: FPDI 1.4.4, TCPDF 6.0.020, FPDF_TPL 1.2.3
  5. Copy the files to "sites/all/libraries/" directory in the Drupal directory into their own "fpdi" and "tcpdf" sub-directories and include "fpdf_tpl.php" in the "fpdi" sub-directory.
  6. Set up a view with a PDF display.
  7. Use it.

Items 3 and 5 are not necessary. Item 4 is not necessary either as long as the recommended versions are included in the module.

Thank you for your time spent on creating/maintaining this module. We've installed it on our site and it works a treat for our needs.

garphy’s picture

garphy CreditAttribution: garphy at ICI LA LUNE commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

.make file are discouraged
.make.example file is the best practice

See #2817897: Rename views_pdf.make to views_pdf.make.example which provide a better patch.

I think this one can be marked as a duplicate.

garphy’s picture

garphy CreditAttribution: garphy at ICI LA LUNE commented
Related issues: +#2817897: Rename views_pdf.make to views_pdf.make.example