The (slightly verbose) title already says it: we have a mechanism for not showing specific processors to the user if the backend "discourages" them, to avoid frequent config mistakes from D7 where Solr is used with Tokenizer or other unnecessary processors.
However, the way it's currently implemented, if you already enabled the processor before moving the index to the server (or before the backend implemented the method or returned that processor's ID) you'll be left without any option to actually disable the processor which you should disable.
So, we shouldn't remove those discouraged processors that are currently enabled but instead notify the user that they should disable them (e.g., via a "warning" message, or with an added note in the processor description).
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2718575-8.patch | 2.12 KB | drunken monkey |
Comments
Comment #2
drunken monkeyThe relevant code is in
\Drupal\search_api\Form\IndexProcessorsForm::form()– I think this is simple enough to count as a "novice" issue.Comment #3
ashishdalviComment #4
anicky commentedComment #5
anicky commentedI added a message in the description of discouraged processors, in bold and on a new line.
If the user unchecks the processor in the list, it disappears then.
Comment #8
anicky commentedComment #11
anicky commentedComment #12
drunken monkeyThanks, nice work!
Just a few small changes in the attached patch, otherwise it looks pretty good.
If these changes look good to you, too, I can commit this.
Comment #13
borisson_Comment #14
anicky commentedIt's ok for me too! Thank you.
Comment #16
drunken monkeyOK, good to hear!
Committed.
Thanks again!