Problem/Motivation

Similar to #2711175: Procedure for re-installing from a contrib profile and fixed in core in #2711645: ConfigInstaller::isSyncing() should return true always during a config sync, this module also suffers the same problem.

Proposed resolution

Implement hook_ENTITY_TYPE_create() and check !$entity->isSyncing()

Remaining tasks

Patch to follow.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 video_embed_field-module_install_from-2718085-6.patch1.02 KBheddn
#2 video_embed_field-module_install_from-2718085-2.patch1.07 KBheddn

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs review
StatusFileSize
new video_embed_field-module_install_from-2718085-2.patch1.07 KB
sam152’s picture

sam152 commented

Drupal\Tests\video_embed_media\Functional\BundleTest will see if this still works even if we have a fail. Running tests regardless.

Status: Needs review » Needs work

The last submitted patch, 2: video_embed_field-module_install_from-2718085-2.patch, failed testing.

sam152’s picture

sam152 commented 
+++ b/modules/video_embed_media/video_embed_media.module
@@ -3,17 +3,17 @@
-use Drupal\video_embed_media\Plugin\MediaEntity\Type\VideoEmbedField;

Looks like the fails are related to this being removed.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review
StatusFileSize
new video_embed_field-module_install_from-2718085-6.patch1.02 KB

Status: Needs review » Needs work

The last submitted patch, 6: video_embed_field-module_install_from-2718085-6.patch, failed testing.

  • Sam152 committed c9da688 on 8.x-1.x authored by heddn 
    Issue #2718085 by heddn: Module install from config results in failed...
sam152’s picture

sam152 commented
Status: Needs work » Fixed

Thanks for working on this.

The last submitted patch, 2: video_embed_field-module_install_from-2718085-2.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 6: video_embed_field-module_install_from-2718085-6.patch, failed testing.

The last submitted patch, 2: video_embed_field-module_install_from-2718085-2.patch, failed testing.

The last submitted patch, 6: video_embed_field-module_install_from-2718085-6.patch, failed testing.

The last submitted patch, 2: video_embed_field-module_install_from-2718085-2.patch, failed testing.

The last submitted patch, 6: video_embed_field-module_install_from-2718085-6.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.