1. Remove the fbl.admin.inc code.
2. Remove @file docblock in the FblConfiguration config form.
3. Remove the inline import
public function buildForm(array $form, \Drupal\Core\Form\FormStateInterface $form_state) {
public function validateForm(array &$form, \Drupal\Core\Form\FormStateInterface $form_state) {
4. Inject the entityManager in buildForm and validateForm instead using the service \Drupal::entityManager().
5. In _fbl_check_for_duplicates, _fbl_user_count and _fbl_field_data_count, Instead of db_select, inject the database service.
6. In all doc blocks, we should have the One line explaintion of the function.
7. Implement the hook_help, function fbl_help($path, $arg) {
8. Remove the inline import \Drupal\Core\Url::fromRoute, in hook_help.
9. Remove hook_menu(), hook_permission()
10. Remove unused functions.
function fbl_field_attach_validate($entity_type, $entity, &$errors) {
function _fbl_field_unique_check($field, $uid, $value) {

Comments

heykarthikwithu created an issue. See original summary.

rakesh.gectcr’s picture

Title: Clean up for Coding standards and Documention. » [META]Clean up for Coding standards and Documention.
Category: Task » Plan
geoanders’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
geoanders’s picture

Assigned: n.kishorekumar » Unassigned
geoanders’s picture

Title: [META]Clean up for Coding standards and Documention. » Coding standards and Documention.

Most are resolved in latest branch, but will be addressed there.

geoanders’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.