CommentFileSizeAuthor
#23 2717041-install-from-service.patch735 bytessam152
#20 2717041-fix-red-test.patch655 bytessam152
#19 Drupal_Tests_video_embed_media_Functional_UpgradePathTest-15-971807.html_.txt21.27 KBalexpott
#15 2717041-fix-red-test.patch2.09 KBsam152
#14 2717041-fix-red-test.patch1.56 KBsam152
#12 2717041-fix-red-test.patch1.39 KBsam152
#7 2717041-meev-test-fix-7.patch979 bytessam152
#2 2717041-meev-test-fix.patch639 bytessam152

Comments

Sam152 created an issue. See original summary.

sam152’s picture

sam152 commented
Status: Active » Needs review
StatusFileSize
new 2717041-meev-test-fix.patch639 bytes

Was it just a random fail?

Status: Needs review » Needs work

The last submitted patch, 2: 2717041-meev-test-fix.patch, failed testing.

The last submitted patch, 2: 2717041-meev-test-fix.patch, failed testing.

The last submitted patch, 2: 2717041-meev-test-fix.patch, failed testing.

The last submitted patch, 2: 2717041-meev-test-fix.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2717041-meev-test-fix-7.patch979 bytes

Still can't repro locally.

Status: Needs review » Needs work

The last submitted patch, 7: 2717041-meev-test-fix-7.patch, failed testing.

The last submitted patch, 7: 2717041-meev-test-fix-7.patch, failed testing.

The last submitted patch, 7: 2717041-meev-test-fix-7.patch, failed testing.

The last submitted patch, 7: 2717041-meev-test-fix-7.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2717041-fix-red-test.patch1.39 KB

Status: Needs review » Needs work

The last submitted patch, 12: 2717041-fix-red-test.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2717041-fix-red-test.patch1.56 KB
sam152’s picture

sam152 commented
StatusFileSize
new 2717041-fix-red-test.patch2.09 KB

The last submitted patch, 14: 2717041-fix-red-test.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 15: 2717041-fix-red-test.patch, failed testing.

sam152’s picture

sam152 commented

To prove I'm not crazy, this is happening locally:

╰─➤  php core/scripts/run-tests.sh --sqlite ~/.d8testing.sqlite --verbose --url http://drupal.core --directory modules/video_embed_field/modules/video_embed_media/tests/src/Functional/

Drupal test run
---------------

Tests to be run:
  - Drupal\Tests\video_embed_media\Functional\BundleTest
  - Drupal\Tests\video_embed_media\Functional\UpgradePathTest

Test run started:
  Tuesday, May 3, 2016 - 13:26

Test summary
------------

Drupal\Tests\video_embed_media\Functional\BundleTest           1 passes
Drupal\Tests\video_embed_media\Functional\UpgradePathTest      1 passes

Test run duration: 1 min 28 sec

Detailed test results
---------------------


---- Drupal\Tests\video_embed_media\Functional\BundleTest ----


Status    Group      Filename          Line Function
--------------------------------------------------------------------------------
Pass      Other      BundleTest.php      36 Drupal\Tests\video_embed_media\Func



---- Drupal\Tests\video_embed_media\Functional\UpgradePathTest ----


Status    Group      Filename          Line Function
--------------------------------------------------------------------------------
Pass      Other      UpgradePathTest.p   37 Drupal\Tests\video_embed_media\Func
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new Drupal_Tests_video_embed_media_Functional_UpgradePathTest-15-971807.html_.txt21.27 KB

Fails locally for me... here is the last page of output that fails the assertion.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2717041-fix-red-test.patch655 bytes

Status: Needs review » Needs work

The last submitted patch, 20: 2717041-fix-red-test.patch, failed testing.

sam152’s picture

sam152 commented

Thanks to @alexpott, this has been tracked down to an infra issue. The modules are being cloned, so they don't have the "version" string, which is now used by media_entity to require entity.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2717041-install-from-service.patch735 bytes

Why does this work for other tests?

sam152’s picture

sam152 commented

  • Sam152 committed ded1b14 on 8.x-1.x 
    Issue #2717041 by Sam152: Fix failing MEEV upgrade test in HEAD
sam152’s picture

sam152 commented
Status: Needs review » Fixed

Good enough fix for me for now. Thanks again for the help @alexpott.

The last submitted patch, 15: 2717041-fix-red-test.patch, failed testing.

The last submitted patch, 20: 2717041-fix-red-test.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 23: 2717041-install-from-service.patch, failed testing.

The last submitted patch, 15: 2717041-fix-red-test.patch, failed testing.

The last submitted patch, 20: 2717041-fix-red-test.patch, failed testing.

The last submitted patch, 23: 2717041-install-from-service.patch, failed testing.

The last submitted patch, 14: 2717041-fix-red-test.patch, failed testing.

The last submitted patch, 20: 2717041-fix-red-test.patch, failed testing.

The last submitted patch, 15: 2717041-fix-red-test.patch, failed testing.

The last submitted patch, 23: 2717041-install-from-service.patch, failed testing.

sam152’s picture

sam152 commented
Status: Needs work » Fixed
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@Sam152 it works because ModuleInstaller::install() does not check requirements - the extension API is super funky.

sam152’s picture

sam152 commented

I suspected as such. In any case, it seems the issue we discovered is likely far less important given modules are usually installed programatically. It explains why this hasn't been an issue for years. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.