See screenshot. For some reason the $pane_row['configuration'] colspan is not used, so the form ends up using only one column.

CommentFileSizeAuthor
#4 fix_checkout_flow_settings_colspan_issue-2715561-4.patch706 bytesagoradesign
bug.png231.89 KBbojanz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented

I actually can't save the settings, getting this error:

Fatal error: Call to a member function submitConfigurationForm() on integer in /var/www/drupalvm/web/modules/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php on line 457

I could swear, that I've already successfully changed settings via UI yesterday!?!

agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented
Assigned: Unassigned » agoradesign
agoradesign’s picture

agoradesign CreditAttribution: agoradesign commented
Status: Active » Needs review
FileSize
fix_checkout_flow_settings_colspan_issue-2715561-4.patch706 bytes

Attached is the patch that fixes the colspan issue.

It turned out, that comment #2 only happens with my custom panes enabled, not with the default ones. Should the cause of that problem also be in Commerce, I'll open a new bug report anyway.

edit: the problem turned out to be fully my fault. And the root of the problem turned out to be a very unobvious and strange one. I've decided to write that down in a blog post, as that was really a mean trap, I've built myself and fallen into: http://www.agoradesign.at/blog/why-it-bad-idea-function-calls-injected-s...

  • bojanz committed cb648fd on 8.x-2.x authored by agoradesign 
    Issue #2715561 by agoradesign: Colspan issue on the checkout flow...
bojanz’s picture

bojanz CreditAttribution: bojanz commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.