Facet calculations are in the wrong order.

Needs test

I'll have a look at this, to try to write a test.

I think this test proves what's wrong, so getting this to pass should be a good start.

The test failed earlier on

fail: [Other] Line 527 of modules/facets/src/Tests/IntegrationTest.php:
"grape (3)" not found

If I change getEnabledFacets in the DefaultFacetManager so it returns this in reverse order, that line passes but it creates a new failure, on line 543 of the test:

"item (1)" found

   public function getEnabledFacets() {
-    return $this->facetStorage->loadMultiple();
+    $facets = $this->facetStorage->loadMultiple();
+    arsort($facets);
+    return $facets;
   } 

This means that the order in which the facets are returned from loadMultiple is the order in which the facets are processed and the count is being added.

I removed that code from the patch, but added a more restrictive assertion in the test. Not sure how we should resolve this, but at least we have an idea to where this comes from.

Rerolled this, still no solution though.

Back to the one expected error. I have no idea how to even start on this.

This, for me, fixes the problem. However, this needs a deep review because I'm not sure we have the same bug.

The test seems to disagree with your solution, and I can't see how that'd make any difference either.

I'm trying to understand why the result is always the same in the case of some facets. Well, if we use the OR query operator by default... then we will build the unfiltered options:

          if ($query_operator === 'OR') {
            $unfiltered_results = $this->facet->getUnfilteredResults();
            $field_identifier = $this->facet->getFieldIdentifier();

            foreach ($unfiltered_results[$field_identifier] as $unfiltered_result) {
              if ($unfiltered_result['filter'] === $result['filter']) {
                $count = $unfiltered_result['count'];
              }
            }
          }

Maybe I'm missing something... anyway let's try with this patch

Following patch should fix the issue for search api datasources. We should not calculate count ourself but rather delegate this to the datasource, as certain backends (e.g. solr) provide this automaticly.

Other data sources then search api should prolly be looked after to provide the correct count too. An example for sql-based sources can be found in search_api_db in Database.php::getFacets()

This patch includes test from #14

+++ b/src/Tests/IntegrationTest.php
@@ -455,6 +455,56 @@ class IntegrationTest extends WebTestBase {
+    $this->drupalGet('admin/config/search/facets/keywords/edit');
+    $edit = [
+      'widget' => 'links',
+      'widget_configs[show_numbers]' => '1',
+    ];
+    $this->drupalPostForm(NULL, $edit, $this->t('Save'));
+    $this->drupalGet('admin/config/search/facets/type/edit');
+    $edit = [
+      'widget' => 'links',
+      'widget_configs[show_numbers]' => '1',
+    ];
+    $this->drupalPostForm(NULL, $edit, $this->t('Save'));

This can be compacted to only 3 lines:

$edit = ['widget' => 'links', 'widget_configs[show_numbers]' => '1'];
$this->drupalPostForm('admin/config/search/facets/keywords/edit', $edit, $this->t('Save'));
$this->drupalPostForm('admin/config/search/facets/type/edit', $edit, $this->t('Save'));

Attached interdiff fixes #27 and fixes the unit test that broke in #23. @StryKaizer is fixing the integration test meanwhile, so not uploading a full patch.

Patch with integrationfix and interdiff from #28

Nits. I will test the patch in the evening.

1. +++ b/facets.module
   @@ -30,12 +30,13 @@ function facets_help($route_name, RouteMatchInterface $route_match) {
   +  if($query->getIndex()->getServerInstance()->supportsFeature('search_api_facets')){
   

   Space around if() parenthesis. See https://www.drupal.org/coding-standards#controlstruct

2. +++ b/src/QueryType/QueryTypeInterface.php
   @@ -10,8 +10,6 @@ interface QueryTypeInterface {
       *
   

   Remove this un-needed line. Just after:

   /**
    * Adds facet info to the query using the backend native query object.
   

Fixes nits from #30.

Is working as expected. Thank you.

Committed, thanks for the reviews and the patches everyone.