Remove unnecessary or unused redirect hooks

What would access do exactly? The standard access operations are called for all entity types (edit, delete) and core doesn't document them anymore for each entity type.

And prepare/validate are no longer called, just documentation left-overs.

I'm trying to use hook_redirect_alter in Redirect 8, but it doesn't appear to be firing.

I want to show a message (via drupal_set_message) to alert the user of why a specific redirect has occurred.

/**
 * Implements hook_redirect_alter().
 */
function custom_redirect_alter($redirect) {
  // Inspect $redirect for specific path and display message.
}

I have removed the hooks hook_redirect_prepare() and hook_redirect_validate() and their documentation.

Thanks. I'm not quite sure what to do about the remaining hooks, IMHO the load hook can be removed as well as the whole block about storage hooks, since that is all generic now.

hook_redirect_load_by_source_alter() also doesn't exist, we should probably remove that as well, if someone needs a feature like that then we can think about adding it, not sure I see the use case right now.

And altering redirects can be done with a response subscriber, redirects can be identified through the X-Redirect-ID header. Maybe we can just document that a bit?

@Berdir

As per your comment i haved kept only one hook hook_redirect_alter.

Hi @Berdir @prashantc

After years patch is not apply, I just recreated patch.

The last patch seems to work.

The patch is applied successfully and it removes the hooks. Marking it as RTC.

Assigning to myself as I'm triaging all RTBC issues.

Thanks, everyone, for the issue, patches, review, and testing.

In #10, the automated testing failed for Drupal 9.2 and PHP 7.3 so moving back to needs work while I take a look:

https://www.drupal.org/pift-ci-job/1997060

Also tagging for better summary.

There are a few hooks that were removed from the code, but not removed from comments.

 /**
  * @} End of "addtogroup hooks".
  */
diff --git a/redirect.module b/redirect.module
index 42371af..6b3e87d 100644
--- a/redirect.module
+++ b/redirect.module
@@ -19,15 +19,6 @@ use Symfony\Component\Routing\Exception\RouteNotFoundException;
  */
 function redirect_hook_info() {
   $hooks = [
-    'redirect_load',
-    'redirect_load_by_source_alter',
-    'redirect_access',
-    'redirect_prepare',
-    'redirect_validate',
-    'redirect_presave',
-    'redirect_insert',
-    'redirect_update',
-    'redirect_delete',
     'redirect_alter',
     'redirect_response',
   ];
Kristens-MacBook-Pro:redirect kristenpol$ 
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_load" .
./redirect.api.php: *   - hook_redirect_load() (all)
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_load_by_source_alter" .
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_access" .
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_prepare" .
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_validate" .
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_presave" .
./redirect.api.php: *   - hook_redirect_presave() (all)
./redirect.api.php: *   - hook_redirect_presave() (all)
./modules/redirect_404/redirect_404.module:function redirect_404_redirect_presave(Redirect $redirect) {
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_insert" .
./redirect.api.php: *   - hook_redirect_insert() (all)
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_update" .
./redirect.api.php: *   - hook_redirect_update() (all)
Kristens-MacBook-Pro:redirect kristenpol$ grep -r "_redirect_delete" .
./redirect.api.php: *   - hook_redirect_delete() (all)
Kristens-MacBook-Pro:redirect kristenpol$ 

Unassigning from me. See comments above.