Given that the module can identify all "cache_*" tables via the Schema API, all cache tables should be automatically ignored, not just the core ones. Also, all of the simpletest tables should be excluded entirely.

CommentFileSizeAuthor
#4 backup_migrate-n2702229-4.patch6.3 KBdamienmckenna
#3 backup_migrate-n2702229-3.patch6.3 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Automatically add all cache tables to the 'nodata' list » Automatically add all cache tables to the 'nodata' list, exclude simpletest tables
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new backup_migrate-n2702229-3.patch6.3 KB

This automatically adds all cache tables to the 'nodata' list and all simpletest tables to the 'exclude' list.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new backup_migrate-n2702229-4.patch6.3 KB

This fixes an unfortunately typo from the original comments ;-)

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I tested #4 with Simpletest installed and confirmed that it does exclude those tables. I was not able to test whether it removes non-core cache tables as I don't know what modules have those. Do you have any examples I could test against? Also, this doesn't affect tables with cache at the end such as the ctools ones.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Thanks @Michelle. A good one is EntityCache, it adds several cache tables for core's supplied entities.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Status: Needs review » Reviewed & tested by the community

I installed EntityCache and confirmed that all of those cache* tables are excluded automatically as well.

Alex Andrascu credited Alex Andrascu.

Alex Andrascu’s picture

Alex Andrascu commented

Pushed to 7.x-3.x-dev.

@DamienMcKenna are you ok to test the latest 7.x-3.x-dev, as I've also pushed a couple of other RTBC's, so we can try and push for a stable release ?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.