[D7] Book outline

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxthomas922692979git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi thomas92,

Please follow this guideline https://www.drupal.org/node/1011698 and https://www.drupal.org/node/1587704 to write a good application description and a project page.

Do not include a LICENSE.txt file in your repository. Drupal.org will add the appropriate version automatically during packaging.

You have a lot of issue related to coding standard https://www.drupal.org/coding-standards:
- you don't have a single comment in your code
- indentation is not standard
- you don't have enough code

In info file you can remove
;$Id$
files[] = book_outline.module

In book_outline.module
- why you define global $base_url and $base_path if you don't use them?
- you have to define the argument in hook_menu instead to read your params with arg() inside your callback.
something like :

$items['book-outline/%'] = array(
function book_outline_view($key)

-line 57
All your function have to be prefixed with your module name.

The project is also far too simple. Once you have the issues mentioned above sorted I think you should be applying for single project promotion

Your getting a huge number of errors on the automated review
http://pareview.sh/pareview/httpgitdrupalorgsandboxthomas922692979git

A little tip. use a text editor to do a find and replace and replace each tab with two spaces. Save you some time editing manually.

Then correct the rest of the errors in the automated review.

Your readme.md is a little short. Although I like the simplicity. If only all module had that detail I woul dhave had a much easier time first learnign Drupal
Take a look at the template - https://www.drupal.org/node/2181737

Automated Review

[Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.]

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

No: List of security issues identified.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) No Drupal coding standards followed. The issues are identified by the Pareview automated tool.
2. (*) Unknown file format exists in module root directory. File named "book_outline-7.x-1.x.sk.po" should be removed.
3. (*) In hook_menu() function, it should be 'type'=>MENU_NORMAL_ITEM instead of 'menu'=>MENU_NORMAL_ITEM
4. (+) In book_outline_view() and book_markup_outline(), Drupal's l() function should be used instead of constructing a link using HTML anchor tag. User facing text should be passed through check_plain() function.
5. Please remove files[] = book_outline.module from book_outline.info file. It is not required to write for .module file as it is by default recognized and loaded by Drupal.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Duplication

This sounds like a feature that should live in the existing Outline Designer project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Outline Designer issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Changing the status to "Postponed".

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.