Closed (fixed)
Project:
Entity Reference Revisions
Version:
8.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
23 Mar 2016 at 09:51 UTC
Updated:
8 Aug 2016 at 10:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
frantisekivanko commentedWith the patch in attachment are paragraphs searchable.
Comment #3
miro_dietikerIMHO Since the concept of a composite relationship is introduced by ERR, it would be that module to resolve the relationship.
Alternatively, Search API could be nice and support our composite pattern definition on its own. It's likely that the code could be easier that way, like your patch also already modifies Search API itself.
Comment #4
miro_dietikerSince we are working more and more with Search API, i'm promoting this issue a bit.
I would love to makes sure a stable release of Paragraphs is well indexable with all expected field flexibility for Search.
Comment #5
killua99 commentedPlus it will need some sort of reroll. Patch doesn't apply
Comment #6
miro_dietikerSupport for Search API was identified as a critical requirement in a current project.
Thus i'm promoting this for our planned stable release and assigning it to team.
Comment #7
johnchqueIt seems that this is a search api issue #2680405: Expose non-base fields in referenced entities in Add Fields. The latest patch fixes it but it also needs tests. In the way for testing we found a bug in here. Uploaded a patch.
Comment #8
miro_dietikerSo now that the referenced issue is committed, what's next?
Comment #9
johnchqueDiscussed with @Berdir, we will extend Paragraphs demo now that search api supports reference fields. #2718875: Extend demo with search api example.
Comment #10
johnchqueThe last patch also fixes a problem in search_api when the @label is not found.
Comment #11
berdirThe patch here is fine, but doesn't really do anything other than fixing that notice.
I'm changing this to a meta issue, please open a specific issue for that notice fix, then we can commit it. Test coverage for #2718875: Extend demo with search api example. will probably require another ERR release but we have to wait on a search_api release anyway as well.
Comment #12
johnchqueIssue opened. #2721531: Fix label on property definitions of Entity reference revisions field type
Comment #13
johnchqueThen this can be active.
Comment #14
miro_dietikerDemoting. We have Search API support now.
Is there anything needed here?
Comment #15
johnchqueI don't think that there is any other thing needed here, we can close this issue.