Closed (fixed)
Project:
Paragraphs
Version:
8.x-1.x-dev
Component:
Demo
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 May 2016 at 15:01 UTC
Updated:
13 Jun 2016 at 08:34 UTC
Jump to comment: Most recent, Most recent file
Search api is recently adding good support for ERR fields. Demo needs to be updated to show the search api support for Paragraphs.
Extend demo.
| Comment | File | Size | Author |
|---|---|---|---|
| #35 | interdiff-2718875-31-35.txt | 847 bytes | johnchque |
| #35 | extend_demo_with_search-2718875-35.patch | 13.01 KB | johnchque |
| #31 | interdiff-2718875-25-31.txt | 444 bytes | johnchque |
| #31 | extend_demo_with_search-2718875-31.patch | 13.17 KB | johnchque |
| #25 | extend_demo_with_search-2718875-25.patch | 13.15 KB | johnchque |
Comments
Comment #2
miro_dietikerPlease connect the issues through references. Or at least add links in body / comments.
Comment #3
johnchqueStill need to add a proper text on the paragraph, maybe we can also add another node with a nested paragraph. At least it works now.
Comment #7
miro_dietiker"Unable to install modules: module 'paragraphs_demo' is missing its dependency module search_api_db."
Please provide a dependency only patch so i can commit it.
Comment #8
johnchqueRight, this goes first.
Comment #10
miro_dietikerCommitted test dependency.
Comment #14
johnchqueDiscussed with @Berdir, there are some things that need to be changed in the first patch. Will have a new one soon.
Comment #15
johnchqueMade some changes, still needs tests.
Comment #16
johnchqueComment #17
johnchqueForgot the interdiff, sorry.
Comment #18
berdirstrange URL for the search, I'd use /paragraph_search or so.
We could consider to get this in without test coverage until search API does a new release. Not sure...
Comment #19
miro_dietikerYeah, it's "just a demo" and not the implementation of the primary functionality we are offering in Demo here.
I would just commit the fix and set it back to needs work to add the test coverage once it applies cleanly after a next Search API release.
Comment #20
berdirSearch API has a new release as of yesterday.
Lets fix the view path and then write a quick test that just goes to the search and searches for something.
While not a requirement, it would be cool to have this in the stable release I think.
Comment #21
johnchqueAdded quick tests, got some problems with schema.
Comment #25
johnchqueI redo everything 3 times literally. Should work now, also passing tests. :D
Comment #29
tduong commentedTested the failing tests and they fail locally as well. Only the paragraphs demo test is passing.
Comment #30
johnchqueComment #31
johnchqueLet's see if it works.
Comment #35
johnchqueYes, it was that easy. Should be fine now. :)
Comment #37
miro_dietikerYay, Committed! :-)