Problem/Motivation

Search api is recently adding good support for ERR fields. Demo needs to be updated to show the search api support for Paragraphs.

Proposed resolution

Extend demo.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

yongt9412 created an issue. See original summary.

miro_dietiker’s picture

Please connect the issues through references. Or at least add links in body / comments.

johnchque’s picture

Status: Active » Needs review
StatusFileSize
new11.35 KB

Still need to add a proper text on the paragraph, maybe we can also add another node with a nested paragraph. At least it works now.

Status: Needs review » Needs work

The last submitted patch, 3: extend_demo_with_search-2718875-3.patch, failed testing.

The last submitted patch, 3: extend_demo_with_search-2718875-3.patch, failed testing.

The last submitted patch, 3: extend_demo_with_search-2718875-3.patch, failed testing.

miro_dietiker’s picture

"Unable to install modules: module 'paragraphs_demo' is missing its dependency module search_api_db."

Please provide a dependency only patch so i can commit it.

johnchque’s picture

Status: Needs work » Needs review
StatusFileSize
new446 bytes

Right, this goes first.

miro_dietiker’s picture

Committed test dependency.

The last submitted patch, 3: extend_demo_with_search-2718875-3.patch, failed testing.

The last submitted patch, 3: extend_demo_with_search-2718875-3.patch, failed testing.

The last submitted patch, 3: extend_demo_with_search-2718875-3.patch, failed testing.

johnchque’s picture

Status: Needs review » Needs work

Discussed with @Berdir, there are some things that need to be changed in the first patch. Will have a new one soon.

johnchque’s picture

StatusFileSize
new11.23 KB

Made some changes, still needs tests.

johnchque’s picture

Status: Needs work » Needs review
johnchque’s picture

StatusFileSize
new3.31 KB

Forgot the interdiff, sorry.

berdir’s picture

+++ b/modules/paragraphs_demo/paragraphs_demo.install
@@ -41,13 +43,28 @@ function paragraphs_demo_install() {
     'field_text_demo' => [
-      'value' => '<p>Apart from the included Paragraph types, you can create your own simply by going to Structure -> Paragraphs types.</p>',
+      'value' => '<p>Apart from the included Paragraph types, you can create your own simply by going to Structure -> Paragraphs types.</p><p>A search api example can be found <a href="/paragraphs_demo">here</a>',
       'format' => 'basic_html',

strange URL for the search, I'd use /paragraph_search or so.

We could consider to get this in without test coverage until search API does a new release. Not sure...

miro_dietiker’s picture

Yeah, it's "just a demo" and not the implementation of the primary functionality we are offering in Demo here.

I would just commit the fix and set it back to needs work to add the test coverage once it applies cleanly after a next Search API release.

berdir’s picture

Status: Needs review » Needs work

Search API has a new release as of yesterday.

Lets fix the view path and then write a quick test that just goes to the search and searches for something.

While not a requirement, it would be cool to have this in the stable release I think.

johnchque’s picture

Assigned: johnchque » Unassigned
Status: Needs work » Needs review
StatusFileSize
new12.73 KB

Added quick tests, got some problems with schema.

Status: Needs review » Needs work

The last submitted patch, 21: extend_demo_with_search-2718875-21.patch, failed testing.

The last submitted patch, 21: extend_demo_with_search-2718875-21.patch, failed testing.

The last submitted patch, 21: extend_demo_with_search-2718875-21.patch, failed testing.

johnchque’s picture

Status: Needs work » Needs review
StatusFileSize
new7.27 KB
new13.15 KB

I redo everything 3 times literally. Should work now, also passing tests. :D

Status: Needs review » Needs work

The last submitted patch, 25: extend_demo_with_search-2718875-25.patch, failed testing.

The last submitted patch, 25: extend_demo_with_search-2718875-25.patch, failed testing.

The last submitted patch, 25: extend_demo_with_search-2718875-25.patch, failed testing.

tduong’s picture

Tested the failing tests and they fail locally as well. Only the paragraphs demo test is passing.

johnchque’s picture

Assigned: Unassigned » johnchque
johnchque’s picture

Status: Needs work » Needs review
StatusFileSize
new13.17 KB
new444 bytes

Let's see if it works.

Status: Needs review » Needs work

The last submitted patch, 31: extend_demo_with_search-2718875-31.patch, failed testing.

The last submitted patch, 31: extend_demo_with_search-2718875-31.patch, failed testing.

The last submitted patch, 31: extend_demo_with_search-2718875-31.patch, failed testing.

johnchque’s picture

Status: Needs work » Needs review
StatusFileSize
new13.01 KB
new847 bytes

Yes, it was that easy. Should be fine now. :)

miro_dietiker’s picture

Status: Needs review » Fixed

Yay, Committed! :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.