It would be nic to have an option to show the icons in a horizontal or vertical layout like the Social Media Links Block module provides ...

CommentFileSizeAuthor
#2 2691891-2.patch15.65 KBxaiwant

Comments

dzinelabs created an issue. See original summary.

xaiwant’s picture

xaiwant commented
Status: Active » Needs review
StatusFileSize
new 2691891-2.patch15.65 KB

Hi @dzinelabs, as per your feature request i have added horizontal/ vertical option in block configuration page to set the social icon layout.

attaching patch.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Needs review » Reviewed & tested by the community

works fine, displays the icons horizontal/vertical based on configuration.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Status: Reviewed & tested by the community » Fixed

Commited..

dzinelabs’s picture

dzinelabs commented

Is the patch a complete rewrite of the php file so i can just copy and paste? It seems to have a lot of code to alter manually and I was not able to find a tool that apply patches to files that are stored on a shared host ...

krknth’s picture

krknth commented

@dzinelabs : you can replace files, follow below link and replace 2 files

https://www.drupal.org/commitlog/commit/84042/4f684387e29dfd633b0fa5182e...

Files are :
/src/Plugin/Block/SimpleSocialIconsBlock.php
/styles/simple_social_icons.css

dzinelabs’s picture

dzinelabs commented

@krknth : patch works as far vertical/horizontal but when choosing vertical the icons get all messed up.

See:

vertical alignment

Block is situated just above footer with title ´Sharing is caring !´

krknth’s picture

krknth commented
Assigned: Unassigned » krknth

@karthik : pls check

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

@dzinelabs, i have checked the site, seems the css has not been applied,

It might be conflicting with the theme or patch must have not applied correctly.

Also try to make fresh clone of code and check.

dzinelabs’s picture

dzinelabs commented

@karthik, works now. Re-upped the css and cleared caches ...works like a charm.

Nice work guys!

xaiwant’s picture

xaiwant commented

cheers @dzinelabs.
nice to hear back from you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.