[policy, no patch] Standardize indenting on chained method calls

+1. I have always used the first example of two spaces.

Some people rather like

  $query = db_select('node');
  $query->condition('type', 'article')
        ->condition('status', 1)
        ->execute();

I'm not sure we should make up rules for this and just let people use whatever they want?

Although Drupal core mostly uses 2 spaces indentation I believe, so it seems to be sort of a convention already.

+1 for 2 spaces, as it's consistent with our other indentation standards.

+1 for 2 spaces. It's also what is used in the DB layer documentation – probably the foremost example of such chained calls.

I agree with the 2 spaces idea, its simply consistent.

Here is a suggested text:

# Nested Function Calls

In case you have a fluid interface for a class, the method calls should be indented with 2 spaces:

$query = db_select('node');
  ->condition('type', 'article')
  ->condition('status', 1)
  ->execute();

+1 for 2 spaces only!

+1 for 2 spaces.

"Me too!" (2 space indent.)

The 3rd variant has some logic to it, but when the first line is not a single variable the alignment point could get very far intended. 2-spaces is nice and consistent and readable.

The TWG has reviewed and is ready to approve this issue. Passing to the core queue for core committer sign-off. If this looks good to core please tag it "Core Committer Approved" and pass back to the TWG queue for documentation updates as per the documented process.

Setting to RTBC to make it visible to core committers.

This rule could be tested programmatically; is there coverage for it in coder?

No, there is no coverage in Coder yet. Please open an issue in the Coder queue.

Ah sorry, of course the Coder issue exists: #2690325: Indentation incorrect on wrapped method calls

Thanks @klausi! Postponing on that issue.

The Coder rule is implemented now.

The next step is to come up with a wording of this rule in the issue summary and where in the coding standards document we are going to put it.

I think no core committer has signed off explicitly yet, although xjm probably did that by asking for the Coder rule? @xjm: can you confirm and add the "Core Committer Approved" tag?

@dawehner has a proposal for the wording in #8.

Marking this RTBC for core committer approval. We can still hash out the details of the wording while awaiting approval.

This was +1'd by alexpott, xjm's points have been done, I'm also +1, so tagging and sending back to TWG.

I'd use 'chained method calls' rather than 'nested function calls' in the docs. Nested function calls I think of as array_keys(array_intersect_key()).

Coding Standards is the correct queue now.

Updating issue summary to reflect suggestion to use 'chained' instead of 'nested', and clarifying that this applies specifically in the multi-line case.

Ratified.

Documentation added to the 'Chaining' section on the Object Oriented code page of the coding standards.

Except it's "fluent", not "fluid".
Should I just go change the docs page directly?

Sure, typo fixes are always allowed :)