Indentation incorrect on wrapped method calls

I think there is no coding standard specified for this - could you link to a place at https://www.drupal.org/coding-standards or subpages that specifies this?

#2690599: [policy, no patch] Standardize indenting on chained method calls has agreed on 2 spaces.

I pushed a start for this, but we will need proper testing for ObjectOperatorIndentSniff.

This now throws a false positive on this structure:

    $membership
      ->setUser($user)
      ->setGroup($collection)
      ->setState(OgMembershipInterface::STATE_ACTIVE)
      ->setRoles([OgRole::load($role_id)])
      ->save();

I get a false positive "Object operator not indented correctly; expected 8 spaces but found 6"

Started on a PR: https://github.com/klausi/coder/pull/10

I am having some failures that seem to be due to a bug in PHP_CodeSniffer. @Klausi maybe you have already encountered this before? The nested_parenthesis seems to be incorrect. I'll explain more in detail on the PR.

edit: there is no bug in PHP_CodeSniffer, I'm stupid.

PR is ready, I have done the following:

• Fixed the false positive from comment #7.
• Added test coverage.
• Added auto-fixers for the indentation, as well as for the sniff that detects if the object operator (->) is at the end of the line.

Changing this also to a feature request, this is not a bug but rather an implementation of a newly defined coding standards.

Thanks, left a couple of comments on the PR.

It looks like your test case from above with $membership is missing?

didn't mean to change the category.

Thanks for the lightning fast review!! I fixed the remarks.

It looks like your test case from above with $membership is missing?

This is actually covered by this part in the test, my example was from Organic Groups, but I replaced it with some core code that exhibits the same problem, this is more recognizable for people unfamiliar with OG:

  $result = $entityTypeManager
    ->getStorage($this->entityTypeId)
    ->loadMultiple($this->ids);

Merged, thanks!

Tested it a bit on core, identified some false positives. Thinking about rewriting the whole sniff, work in progress at https://github.com/klausi/coder/pull/13

Rewrote the sniff and all fixes for Drupal core look good now.