Remove drupal_render deprecated method and refactor non-functional cleanups

I do prefer to commit deprecated and other non-functional clean-up fixes as a combined patch.

We should preferrably work through all the positive reports at "PHPStorm Code - Inspect Code" in this issue.

Good job! But after going to admin/help/entity_reference_revisions there were some errors/exceptions, so you need to fix (+ small refactoring) as follow:

1. +++ b/entity_reference_revisions.module
   @@ -21,11 +21,11 @@ function entity_reference_revisions_help($route_name, RouteMatchInterface $route
   +      $output .= '<p>' . t('The Entity Reference Revisions module allows you to create fields that contain links to other entities (such as content items, taxonomy terms, etc.) within the site. This allows you, for example, to include a link to a user within a content item. For more information, see <a href="!er_do">the online documentation for the Entity Reference Revisions module</a> and the <a href="!field_help">Field module help page</a>.', array('!field_help' => Url::fromRoute('help.page', array('name' => 'field')), '!er_do' => 'https://drupal.org/documentation/modules/entity_reference_revisions')) . '</p>';
   

   Call ->toString() after Url::formRoute() (like Url::fromRoute(...)->toString()), and replace the " ! " with " : ", for :field_help, :er_do and ...

2. +++ b/entity_reference_revisions.module
   @@ -21,11 +21,11 @@ function entity_reference_revisions_help($route_name, RouteMatchInterface $route
   +      $output .= '<dd>' . t('The <em>settings</em> and the <em>display</em> of the entity reference field can be configured separately. See the <a href="!field_ui">Field UI help</a> for more information on how to manage fields and their display.', array('!field_ui' => Url::fromRoute('help.page', array('name' => 'field_ui')))) . '</dd>';
   

   ... for :field_ui, also call ->toString() here as well.
   And add the Drupal\Core\Url import.

1. +++ b/entity_reference_revisions.views.inc
   @@ -12,7 +12,7 @@ use Drupal\field\FieldStorageConfigInterface;
   diff --git a/src/EntityReferenceRevisionsFieldItemList.php b/src/EntityReferenceRevisionsFieldItemList.php
   

   Saw an unused import in this class (use Drupal\Core\Field\FieldItemList).

2. +++ b/src/Plugin/views/style/EntityReferenceRevisions.php
   @@ -92,7 +92,7 @@ class EntityReferenceRevisions extends StylePluginBase {
   diff --git a/src/Tests/EntityReferenceRevisionsAutocompleteTest.php b/src/Tests/EntityReferenceRevisionsAutocompleteTest.php
   

   Please fix the path of the class docblock (missing Tests subclass).

Otherwise looks fine to me! :)

@sskt please also upload intermediate patches to make tests run.

@sskt just do "\Drupal\entity_reference_revisions\Tests\EntityReferenceRevisionsAutocompleteTest."
And yes, please add also the interdiff file to easily review your changes between two patches (if you wonder how to do that, see https://www.drupal.org/documentation/git/interdiff).

Great! Just a small standard coding:

+++ b/src/Plugin/views/style/EntityReferenceRevisions.php
@@ -2,7 +2,7 @@
+ * Contains \Drupal\entity_reference_revisions\src\Plugin\views\style\EntityReferenceRevisions.

This was fine. Usually you don't write src in the path/namespace.
Here you can find the @file Documenting files and Namespaces standard coding documentations. Just revert this line.

Otherwise everything is fine for me! :)

Yep, looks good to me!

1. +++ b/src/Plugin/Field/FieldFormatter/EntityReferenceRevisionsEntityFormatter.php
   @@ -92,7 +92,7 @@ class EntityReferenceRevisionsEntityFormatter extends EntityReferenceRevisionsFo
   +      '#options' => \Drupal::entityTypeManager()->getViewModeOptions($this->getFieldSetting('target_type')),
   
   @@ -107,7 +107,7 @@ class EntityReferenceRevisionsEntityFormatter extends EntityReferenceRevisionsFo
   +    $view_modes = \Drupal::entityTypeManager()->getViewModeOptions($this->getFieldSetting('target_type'));
   
   +++ b/src/Plugin/Field/FieldType/EntityReferenceRevisionsItem.php
   @@ -252,10 +252,10 @@ class EntityReferenceRevisionsItem extends EntityReferenceItem implements Option
   +          $entity = \Drupal::entityTypeManager()->loadEntityByUuid($target_entity_type->id(), $default_value['target_uuid']);
   

   These things are wrongly converted. The methods have been moved to different managers...

   It also means there is no test coverage for that, and we want to fix this.

Just rerolled, solved a merge conflict.
Not sure how the conversions mentioned in should be fixed...

Don't know what happened with the previous interdiff... Anyway, reverted too much, set back "entity_view" in EntityReferenceRevisionsEntityFormatter::viewElements().

+++ b/src/Plugin/Field/FieldFormatter/EntityReferenceRevisionsEntityFormatter.php
@@ -107,7 +107,7 @@ class EntityReferenceRevisionsEntityFormatter extends EntityReferenceRevisionsFo
+    $view_modes = \Drupal::entityTypeManager()->getViewModeOptions($this->getFieldSetting('target_type'));

Fatal: This is not provided by EntityTypeManager. Newly only on EntityDisplayRepository provided by getViewModeOptions on EntityManagerWrapper.

Also i still see no new tests.

Replaced the wrong conversions:
- injected $entityDisplayRepository in EntityReferenceRevisionsEntityFormatter
- used \Drupal::getContainer()->get('entity.repository') in EntityReferenceRevisionsItem

I've just learnt something new and dropped all @file comments for classes / interfaces / traits according to the @file doc standard coding.

I think the test for the view mode options (called by EntityDisplayRepositoryInterface) is already covered in EntityReferenceRevisionsAdminTest.
Not sure about the other one: what is the good approach to test the new conversion in EntityReferenceRevisionsItem to check loading entity by uuid ?

Unrelated code cleanups are not accepted. :-)
File a separate issue. It makes reviewing hard and if you have multiple issues like that the patches conflict!

The test can not have been covered - otherwise it would have failed.

loadEntityByUuid() is about the default value. Create a field and check config if the dependencies are properly created.

Interdiff against patch #20:
- fix wrong manager conversions
- test checking the configuration dependencies

Created follow-up #2709241: Drop @file path documentation according to standard coding

Need to think how to get a failing test_only patch.

Rerolled. @Berdir said he will take a look for this test as soon as he has time.

Ok, this is a bit more complicated. Lets go back to just do the fix without changing the test here, and open a new issue to test entity reference revisions default values and configuration dependencies.

Basically, what you need to do is the following:

'default_value' => [
[
'target_id' => $composite->id(),
'revision_id' => $composite->getRevisionId(),
]
]

To the field config, so it uses that reference as the default. When you try that, you'll notice that you get an invalid config schema error, we are missing schema for the field type value. The new issue can do that.

Dropped test and shortened the "array syntax" according to the array standard coding (just in entity_reference_revisions.module for now). This is not *that* important, but since this issue is about "deprecated and other non-functional clean-up fixes" it may make sense to edit them here for the whole ERR module, but sure it will conflict with a lot of other issues...

Created follow-up: #2711429: Test ERR default values and configuration dependencies.

We should definitely be careful with mixing so many changes. However, only one case seems to touch code that doesn't already change, so that's pretty OK.

Committing this, changes also look fine for me.