Active items of continuous jobs not showing up on the sources overview

The reason is, as stated in other issues, our API to load the last active item is not returning items from the continuous job.

Much confusing in using the UI.

Yes, that is correct. But we have at least one additional function that has a similar condition.

In fact, you should check and review all active/unprocessed checks/references and checks like that and check if it should apply to continuous as well.

If that's the only ones then fine, still needs tests. We should be able to extend some of the existing continuous UI tests, visit the sources page and confirm you see a link to an existing job item there.

1. +++ b/sources/content/src/Tests/ContentEntitySourceUiTest.php
   @@ -671,6 +671,10 @@ class ContentEntitySourceUiTest extends EntityTestBase {
   +    $items = $continuous_job->getItems();
   +    $item = reset($items);
   

   There was a problem in Collect a while ago, that order was not guaranteed with reset() function. The problem especially occurred on Test bot.

   But, it seems that you have only one element here...

2. +++ b/tmgmt.module
   @@ -153,7 +153,7 @@ function tmgmt_job_item_load_latest($plugin, $item_type, $item_id, $source_langu
   +    ->condition('tj.state', array(Job::STATE_UNPROCESSED, Job::STATE_ACTIVE, Job::STATE_CONTINUOUS), 'IN')
   

   To be consistent, I would say "array()" or "[]" syntax for both conditions.

3. +++ b/tmgmt.module
   @@ -440,7 +440,7 @@ function tmgmt_translator_load_available($job) {
   +      ->condition('state', [Job::STATE_ACTIVE, Job::STATE_CONTINUOUS], 'IN')
   

   You can remove 1 extra tab here.

Let's add some debug and see if the icon is found.

Lets add a new debug to see what is going on here. :)

I knew it, testbot!, checking the link the testbot adds a '/checkout' preffix to the link. Maybe asserting in this way can also work.

Interdiff with patch 14. :)

+++ b/sources/content/src/Tests/ContentEntitySourceUiTest.php
@@ -671,6 +671,10 @@ class ContentEntitySourceUiTest extends EntityTestBase {
     $this->assertUniqueText(t("1 continuous job item has been created."));
 
+    $items = $continuous_job->getItems();
+    $item = reset($items);
+    $this->assertRaw('/admin/tmgmt/items/' . $item->id(), 'Link to job item available.');
+

Why not use assertLinkByHref() ? It by default does a partial match, so it shouldn't matter if it has /checkout or not.

That looks good now, yes.