Closed (outdated)
Project:
Drupal 8 Contrib Porting Tracker
Version:
8.x-0.x-dev
Component:
Module
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
1 Mar 2016 at 15:26 UTC
Updated:
1 Sep 2025 at 22:42 UTC
Jump to comment: Most recent
Comments
Comment #2
prateekS commentedComment #3
zeeshan_khan commentedComment #4
devtherock commentedComment #5
devtherock commentedComment #6
devtherock commentedComment #7
Benia commentedShould be in D8 core.
Comment #8
rahulbaisanemca commentedHi prateekS,
Given git link https://git.drupal.org/project/image_caption.git is not working
can you please update it.
Thanks,
Rahul.
Comment #9
geraldito commentedThe correct link is http://cgit.drupalcode.org/image_caption but there is nothing to see from D8 development. Anybody working on that?
Comment #10
MaskyS commentedComment #11
MaskyS commentedComment #12
MaskyS commentedComment #13
MaskyS commentedSorry, made editswrong issue
Comment #14
mmjvb commented@Kifah Meeran How far do the mistakes go? Are you working on this or not?
Comment #15
MaskyS commented@mmjvb I am indeed working on this. I hope to add my sandbox link here in a few hours, once I am sure my module is functional.
Comment #16
MaskyS commentedComment #17
MaskyS commentedMy sandbox is finally functional (Link in issue summary above). Here are some things that are different from the D7 version:
- The user now has to choose whether to use JQuery or Input Filter method to create & display captions, in order to prevent both filters from processing the same image. Besides, using both modules would not have any benefits. If the user wanted to style captions in different ways, he could use different styles along with the "Without Javascript" option.
- Coding standards have been fixed, including the changes in #2765965.
- Issue #785664 has been fixed.
- Issue #2458101 has been fixed.
- Issue #1918618 has been fixed.
- Issue #1403474 has been fixed.
- Issue #1889266 has been fixed.
- Readme has been updated to follow the README Template and now contains more information.
Why did I choose to go ahead with these fixes before they were commited to the 7.1x branch?
1) They work
2) Some of these were postponed due to possible incompatibility with browsers (namely IE 9 and below), but those are no longer supported now, and HTML5 elements now work in 98% of browsers.. Drupal itself states that it is compatible IE 11 and above.
3) The maintainer has been inactive for years.
Work that remains to be done:
These are listed directly on the issue queue of the sandbox. (https://www.drupal.org/project/issues/2933889)
I will also try to contact the maintainer to try and get a 8.1x branch in the official project's repo.
Comment #18
MaskyS commentedComment #19
avpadernoComment #20
avpadernoThe project does not have releases for supported Drupal versions.