Active
Project:
Drupal core
Version:
main
Component:
views_ui.module
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Feb 2016 at 16:52 UTC
Updated:
11 Dec 2025 at 19:14 UTC
Jump to comment: Most recent
From the parent issue:
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.phpundefined
@@ -937,4 +937,86 @@ public static function breakPhraseString($str, &$handler = NULL) {
+ // @todo Decide if \Drupal\views_ui\Form\Ajax\ViewsFormBase::getForm() is
+ // perhaps the better place to fix the issue.
+ // \Drupal\views_ui\Form\Ajax\ViewsFormBase::getForm() drops the current
+ // form from the stack, even if it's an #ajax. So add the item back to the top
+ // of the stack.
+ $form_state['view']->addFormToStack($form_state['form_key'], $form_state['display_id'], $type, $item['id'], TRUE);
That seems worth a follow-up as well.
Comments
Comment #15
smustgrave commentedThank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Comment #16
smustgrave commentedThe todo is still there so need to be investigated if still needed and documented why.
Comment #17
lokapujyaWhen the parent issue was fixed, it was unclear what where the best place to deal with adding the form back on the stack.
The @todo is in submitTemporaryForm() which is a function in the base class for Views handler plugins. Here is the comment header for submitTemporaryForm():
* A submit handler that is used for storing temporary items when using
* multi-step changes, such as ajax requests.
The code in getForm() which is in ViewsFormBase.php deals with the stack of forms.
Perhaps, the first step is to identify what steps to take in the UI that trigger this functionality.
Comment #18
lokapujyaI don't think there is a bug, so the @todo could be removed. In order to make a decision, it would be an interesting to first understand how the views UI multi-step forms work, and possibly make a diagram showing the flow.