Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When we open popup "Rearrange filter criteria" links 'Create new filter group' & 'Show row weights' not in one line. Click zone for this links is full header width.
Comment | File | Size | Author |
---|---|---|---|
#15 | views_ui_rearrange_filter-2675522-15.patch | 632 bytes | gvso |
#13 | rearrange-filter-criteria-image.png | 32.61 KB | kostyashupenko |
#13 | interdiff.txt | 758 bytes | kostyashupenko |
#13 | views_ui_rearrange_filter-2675522-13.patch | 634 bytes | kostyashupenko |
#7 | interdiff-views_ui_rearrange_filter-2675522-7.txt | 993 bytes | HOG |
Comments
Comment #2
HOG CreditAttribution: HOG at Skilld commentedLinks display fixed.
Comment #3
andypostComment #4
gvsoShoudn't this issue only focus on the CSS part. The related issue is already about the duplicated/unused variable.
Comment #5
HOG CreditAttribution: HOG at Skilld commentedHow to test:
Comment #6
gvsoIt seems I changed the status before @HOG described how to test it
Comment #7
HOG CreditAttribution: HOG at Skilld commentedComment #8
dawehner@HOG or someone else
Do you mind posting a screenshot of before and after?
Comment #9
gvsoBefore patch
After patch
Comment #10
dawehnerThank you! Well I would like to RTBC it, but I cannot judge CSS :(
Comment #11
gvsoI'm not good at CSS, but it seems the patch is not following the coding standards
Comment #12
kostyashupenkoComment #13
kostyashupenko@HOG, the code below is not work for IE browsers properly
.views-ui-rearrange-filter-form table:before {
clear: both;
content: ".";
display: block;
height: 0;
visibility: hidden;
}
I removed these styles and added margin-bottom: 1em to elements above table tag. For now styles works the same like with the patch of @HOG, but works and for IE. Check screen
Needs review
Comment #14
gvsoThe formatting guidelines states
Comment #15
gvsoI just removed the blank lines in #13. It seems this file has many unnecessary blank lines between rulesets which doesn't happen in other css files. Maybe we need to create another issue to remove them.
Comment #16
pradeep22saini CreditAttribution: pradeep22saini commentedthanks for the patch:
Steps used to test:
1. Fresh installed the drupal 8 site.
2. created a view.
3. checked set the filtered criteria and rearranged
4. Create new filter group and Show row weights was not coming in one line.
Applied the patch #15
checked in chrome.
safari and firefox coming fine.
checked in different responsive view looking good.
Remianing IE browser testing else looks good.
Comment #17
cilefen CreditAttribution: cilefen commented@pradeep22saini Is this ready to be marked "Reviewed and tested by the community" status?
Comment #18
pradeep22saini CreditAttribution: pradeep22saini commentedYes, it's working fine in IE also.
Comment #19
catchComment #20
star-szrComment #22
star-szrSince this is a visual change and not functionally broken, committing to 8.2.x only. I manually tested and it looks great. Thanks all :)
Note: I made a minor whitespace change on commit to try to preserve the intent of the linebreaks grouping the CSS rules, the patch was deleting a linebreak that I think was intended to group/separate things.