Support from Acquia helps fund testing for Drupal Acquia logo

Comments

HOG created an issue. See original summary.

HOG’s picture

Links display fixed.
Views Ui rearrange filter

andypost’s picture

Issue tags: -views ui +VDC
Related issues: +#2302515: Duplicate/unused variable 'dropdowns' in duplicateGroupsOperator() in views-admin.js
gvso’s picture

Status: Needs review » Needs work
+++ b/core/modules/views_ui/js/views-admin.js
@@ -797,7 +797,7 @@
-        dropdowns = dropdowns.add(fakeOperator);
+        dropdowns.add(fakeOperator);
       }

Shoudn't this issue only focus on the CSS part. The related issue is already about the duplicated/unused variable.

HOG’s picture

Status: Needs work » Needs review

How to test:

  1. Open link: admin/structure/views/view/content
  2. On filter group click on arow (after Add lunk)
  3. Select 'Add or reange'
  4. You see popup: 'Page: Rearrange filter criteria'
gvso’s picture

Status: Needs review » Needs work

It seems I changed the status before @HOG described how to test it

HOG’s picture

dawehner’s picture

Issue tags: +Needs screenshots

@HOG or someone else
Do you mind posting a screenshot of before and after?

gvso’s picture

Before patch

After patch

dawehner’s picture

Issue tags: -Needs screenshots

Thank you! Well I would like to RTBC it, but I cannot judge CSS :(

gvso’s picture

Status: Needs review » Needs work

I'm not good at CSS, but it seems the patch is not following the coding standards

kostyashupenko’s picture

Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

Assigned: kostyashupenko » Unassigned
Status: Needs work » Needs review
FileSize
634 bytes
758 bytes
32.61 KB

@HOG, the code below is not work for IE browsers properly

.views-ui-rearrange-filter-form table:before {
clear: both;
content: ".";
display: block;
height: 0;
visibility: hidden;
}

I removed these styles and added margin-bottom: 1em to elements above table tag. For now styles works the same like with the patch of @HOG, but works and for IE. Check screen
filter criteria

Needs review

gvso’s picture

Status: Needs review » Needs work
+++ b/core/themes/seven/css/components/views-ui.css
@@ -236,10 +236,16 @@ details.fieldset-no-legend {
   padding: 0;
 }
 
+.views-ui-rearrange-filter-form .tabledrag-toggle-weight-wrapper {
+  float: right;
+  margin-bottom: 1em;
+}
+
 .views-ui-rearrange-filter-form table {

The formatting guidelines states

In general, do NOT separate each ruleset by a blank line. If two rulesets have no interleaving blank line, they must be logically related. If they are not logically related to each other, add a blank line and a comment describing the second ruleset.
gvso’s picture

Status: Needs work » Needs review
FileSize
632 bytes

I just removed the blank lines in #13. It seems this file has many unnecessary blank lines between rulesets which doesn't happen in other css files. Maybe we need to create another issue to remove them.

pradeep22saini’s picture

thanks for the patch:

Steps used to test:
1. Fresh installed the drupal 8 site.
2. created a view.
3. checked set the filtered criteria and rearranged
4. Create new filter group and Show row weights was not coming in one line.

Applied the patch #15
checked in chrome.
safari and firefox coming fine.
checked in different responsive view looking good.

Remianing IE browser testing else looks good.

cilefen’s picture

@pradeep22saini Is this ready to be marked "Reviewed and tested by the community" status?

pradeep22saini’s picture

Status: Needs review » Reviewed & tested by the community

Yes, it's working fine in IE also.

catch’s picture

Title: Views Ui rearrange filter » Styling for Views UI rearrange filters
Version: 8.0.x-dev » 8.1.x-dev
star-szr’s picture

Assigned: Unassigned » star-szr

  • Cottser committed 1d6eb8f on 8.2.x
    Issue #2675522 by HOG, kostyashupenko, gvso, dawehner, pradeep22saini:...
star-szr’s picture

Version: 8.1.x-dev » 8.2.x-dev
Assigned: star-szr » Unassigned
Status: Reviewed & tested by the community » Fixed

Since this is a visual change and not functionally broken, committing to 8.2.x only. I manually tested and it looks great. Thanks all :)

Note: I made a minor whitespace change on commit to try to preserve the intent of the linebreaks grouping the CSS rules, the patch was deleting a linebreak that I think was intended to group/separate things.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.