Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
There is an unused duplicate variable 'dropdowns' in duplicateGroupsOperator() in views-admin.js.
Proposed resolution
Remove. Patch below.
Remaining tasks
None.
User interface changes
None.
API changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #25 | interdiff-duplicate_unused-2302515-19-25.txt | 818 bytes | HOG |
| #25 | duplicate_unused-2302515-25.patch | 539 bytes | HOG |
| #21 | interdiff-duplicate_unused-2302515-21.txt | 1.54 KB | HOG |
| #21 | duplicate_unused-2302515-21.patch | 1.33 KB | HOG |
| #3 | drupal-views-duplicate-dropdowns-var-2302515-3.patch | 1.24 KB | Elijah Lynn |
Comments
Comment #1
Elijah LynnComment #3
Elijah LynnAhh, this patch #2301953: Update 'element-invisible' and 'element-hidden' to valid Drupal 8 CSS classes just got applied causing it to fail. Re-rolled.
Comment #4
Elijah LynnComment #5
LinL CreditAttribution: LinL commentedAdding js tag.
Comment #6
droplet CreditAttribution: droplet commentedI think it's more than "dropdowns"
http://cgit.drupalcode.org/drupal/tree/core/modules/views_ui/js/views-ad...
"titleRow" and some other expressions.
Comment #7
Elijah LynnYeah, there are a bunch more in that file but I wasn't sure if I should make separate issues for each one?
Comment #8
droplet CreditAttribution: droplet commentedthat's fine to clean up in same issue, we did a lot of these cleanups before: #1415788: Javascript winter clean-up
Comment #9
nod_Comment #10
camoa CreditAttribution: camoa at Camo Advanced Tech commentedThis should move the cleanup further.
I think that will do it as a clean up, there is some repeated code but it is not repeated functionality.
Comment #11
camoa CreditAttribution: camoa at Camo Advanced Tech commentedComment #13
droplet CreditAttribution: droplet commentedComment #14
Alka Kumari CreditAttribution: Alka Kumari as a volunteer commentedComment #15
kostyashupenkoRe-roll of patch #10
Comment #16
andypoststill needs proper re-roll
Comment #17
kostyashupenkoNot sure that we still need re-roll, because there was an auto merge. Better to make a patch
Comment #18
gvsoIf we remove
dropdowns = this.operator,drow dropdowns = dropdowns.add(fakeOperator);will produce an error.Comment #19
eleleka CreditAttribution: eleleka at Skilld commentedRerolled patch #10
There is some confusion in line numbers
Comment #20
droplet CreditAttribution: droplet commentedPlease also check the code and do manual tests during reroll.
Comment #21
HOG CreditAttribution: HOG at Skilld commentedEdited last path, as it not worked correctly. Added styles for filter sort table header for pretty display. Patch work ok now as i see, but i find new error after add new group:
Uncaught TypeError: Cannot read property 'width' of undefined. In function Drupal.dialog~resetSize
Comment #22
droplet CreditAttribution: droplet commentedWe shouldn't do multiple changes in one issue. Please open an issue for CSS part.
is it caused by this patch ?
Comment #23
kostyashupenkoComment #24
HOG CreditAttribution: HOG at Skilld commented@droplet, js bug is in 8.0.x branch also.
About multiple changes i separate it now.
Comment #25
HOG CreditAttribution: HOG at Skilld commentedComment #26
zeeshan_khan CreditAttribution: zeeshan_khan as a volunteer commentedLooks good to me ;)
Thanks @HOG
Comment #27
HOG CreditAttribution: HOG at Skilld commentedFiled follow-up issue for CSS #2675522: Styling for Views UI rearrange filters
Comment #28
HOG CreditAttribution: HOG at Skilld commentedHow to test:
Comment #30
catchCommitted/pushed to 8.1.x, thanks!
This is just clean-up so not eligible for 8.0.x.