Problem/Motivation

There is an unused duplicate variable 'dropdowns' in duplicateGroupsOperator() in views-admin.js.

Proposed resolution

Remove. Patch below.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Files: 
CommentFileSizeAuthor
#25 interdiff-duplicate_unused-2302515-19-25.txt818 bytesHOG
#25 duplicate_unused-2302515-25.patch539 bytesHOG
#21 interdiff-duplicate_unused-2302515-21.txt1.54 KBHOG
#21 duplicate_unused-2302515-21.patch1.33 KBHOG
#3 drupal-views-duplicate-dropdowns-var-2302515-3.patch1.24 KBElijah Lynn
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,207 pass(es). View
#1 drupal-views-duplicate-dropdowns-var-2302515-1.patch1.24 KBElijah Lynn
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal-views-duplicate-dropdowns-var-2302515-1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

Elijah Lynn’s picture

Status: Active » Needs review
FileSize
1.24 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch drupal-views-duplicate-dropdowns-var-2302515-1.patch. Unable to apply patch. See the log in the details link for more information. View

Status: Needs review » Needs work

The last submitted patch, 1: drupal-views-duplicate-dropdowns-var-2302515-1.patch, failed testing.

Elijah Lynn’s picture

Status: Needs work » Needs review
FileSize
1.24 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 73,207 pass(es). View

Ahh, this patch #2301953: Update 'element-invisible' and 'element-hidden' to valid Drupal 8 CSS classes just got applied causing it to fail. Re-rolled.

Elijah Lynn’s picture

LinL’s picture

droplet’s picture

Status: Needs review » Needs work

I think it's more than "dropdowns"

http://cgit.drupalcode.org/drupal/tree/core/modules/views_ui/js/views-ad...

"titleRow" and some other expressions.

Elijah Lynn’s picture

Yeah, there are a bunch more in that file but I wasn't sure if I should make separate issues for each one?

droplet’s picture

that's fine to clean up in same issue, we did a lot of these cleanups before: #1415788: Javascript winter clean-up

nod_’s picture

Issue tags: +Novice
camoa’s picture

FileSize
1.21 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,592 pass(es). View

This should move the cleanup further.

I think that will do it as a clean up, there is some repeated code but it is not repeated functionality.

camoa’s picture

Status: Needs work » Needs review

droplet’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll
Alka Kumari’s picture

Assigned: Unassigned » Alka Kumari
Issue tags: +drupalconasia2016
kostyashupenko’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
675 bytes

Re-roll of patch #10

andypost’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

still needs proper re-roll

kostyashupenko’s picture

Not sure that we still need re-roll, because there was an auto merge. Better to make a patch

gvso’s picture

If we remove dropdowns = this.operator, drow dropdowns = dropdowns.add(fakeOperator); will produce an error.

eleleka’s picture

Assigned: Alka Kumari » Unassigned
Status: Needs work » Needs review
FileSize
1.21 KB

Rerolled patch #10
There is some confusion in line numbers

droplet’s picture

Status: Needs review » Needs work

Please also check the code and do manual tests during reroll.

HOG’s picture

Edited last path, as it not worked correctly. Added styles for filter sort table header for pretty display. Patch work ok now as i see, but i find new error after add new group:
Uncaught TypeError: Cannot read property 'width' of undefined. In function Drupal.dialog~resetSize

droplet’s picture

Status: Needs review » Needs work

We shouldn't do multiple changes in one issue. Please open an issue for CSS part.

i find new error after add new group:
Uncaught TypeError: Cannot read property 'width' of undefined. In function Drupal.dialog~resetSize

is it caused by this patch ?

kostyashupenko’s picture

Issue tags: -Needs reroll
HOG’s picture

@droplet, js bug is in 8.0.x branch also.
About multiple changes i separate it now.

HOG’s picture

Status: Needs work » Needs review
FileSize
539 bytes
818 bytes
zeeshan_khan’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me ;)
Thanks @HOG

HOG’s picture

HOG’s picture

How to test:

  1. Open link: admin/structure/views/view/content
  2. On filter group click on arow (after Add lunk)
  3. Select 'Add or reange'
  4. You see popup: 'Page: Rearrange filter criteria'

  • catch committed ff06c79 on 8.1.x
    Issue #2302515 by HOG, Elijah Lynn, kostyashupenko, camoa, eleleka:...
catch’s picture

Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x, thanks!

This is just clean-up so not eligible for 8.0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.