Problem/Motivation
Follow up from #2640994: Fix label token replacement for views entity reference arguments (see #30).
... we have large list of argument classes that could either be replaced completely by this new generic argument plugin or at least extend from it (although some extend from others like ManyOne). Many of those are for example missing the translation context thing and would not be displayed in the right translation. An incomplete list:
* \Drupal\taxonomy\Plugin\views\argument\Taxonomy (is missing the translation context thing)
* \Drupal\taxonomy\Plugin\views\argument\VocabularyVid
* \Drupal\taxonomy\Plugin\views\argument\IndexTid
* \Drupal\taxonomy\Plugin\views\argument\IndexTidDepth
* \Drupal\user\Plugin\views\argument\RolesRid
* \Drupal\comment\Plugin\views\argument\UserUid
* \Drupal\node\Plugin\views\argument\Nid... if we have to update views configurations, it might be easier to just do them in one go.
Proposed resolution
1) Extend all existing argument classes from the new EntityArgument that can benefit from that code
2) (optional) Deprecate those that have no own code left
Comments
Comment #15
dwwThis is now being done in #2640994: Fix label token replacement for views entity reference arguments, which is almost ready to commit. 🎉