We should review the code to be sure it follows Drupal8 coding standards. (https://www.drupal.org/coding-standards)

These not have changed that much between D7 and D8.

Main task will probably be to update array to use short syntax (see discussion here: https://www.drupal.org/node/2135291)

Comments

vbouchet created an issue. See original summary.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented

Should this be a large issue or chunked? (ie into css, js, php (my inclination) or into specific fixes?)

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet at Acquia commented
Title: Implements d8 coding standard » [META] Implements d8 coding standard

I renamed the ticket so we can list the various standards we should review and create appropriate tickets.

dishabhadra’s picture

dishabhadra CreditAttribution: dishabhadra at Blisstering Solutions, Iksula commented

Hi All,

I am fixing the phpcs issues as per coding standards.

I created new issue : https://www.drupal.org/node/2807007

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Active » Fixed

Pretty much done - some work on the schema is needed for cycle but core is good.

NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.