Having a different number of results for the first slide of slideshow is a handy feature - see MSN homepage for an example.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | different_number_of-2665150-9.patch | 8.8 KB | vbouchet |
| #2 | different_number_of-2665150-2.patch | 8.83 KB | nickdickinsonwilde |
Comments
Comment #2
nickdickinsonwildeComment #9
vbouchetHi NickWilde,
Please find an updated patch. I only fixed minor typo (unexisting variable name, too many spaces) and updated (or rollbacked) your array implementation. I know the D8 style should be
$var = [];as you did, but there entire project currently use the old-fashion implementation. So I would prefer to avoid mixing syntax and will create a dedicated ticket to update code syntax.I tested the patch and it works well, it only requires some theming but it is specific to each project ;-)
Let me know if it's ok for you and will merge it. Thanks,
Comment #11
nickdickinsonwildeYeah - I much prefer the [] syntax but I can definitely see the arguments for doing it as a single issue rather than piecemeal. (to be clear, I'm totally good with it)
Comment #12
nickdickinsonwildeBack to [] syntax since everything else is. Fair bit of reworking on this actually.