* The response policy is evaluated in order to determine whether a page should
 * be stored a in the cache. Calling code should do so unless static::DENY is
 * returned from the check() method.

I presume "be stored a in the cache" wanted to be "be stored in the cache". Also, dynamic page cache should be mentioned. Finally, no_cache: TRUE in routing.yml should be mentioned.

Comments

chx created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: cache system » page_cache.module

+1

This is not the cache system though, it's the Page Cache system. znerol is the maintainer for that, he worked on this. I'm sure he'll be able to clarify it.

chx’s picture

chx commented

Well the namespace is Drupal\Core\PageCache so it can't be a module :/

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2263981: Introduce a robust and extensible page cache-policy framework

#2263981: Introduce a robust and extensible page cache-policy framework introduced this.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2540684: Rename Drupal\Core\PageCache namespace

Well the namespace is Drupal\Core\PageCache so it can't be a module :/

I totally agree, that's why we have #2540684: Rename Drupal\Core\PageCache namespace.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » znerol
znerol’s picture

znerol commented

If someone is going to reword that, then please use the term http cache in place of page cache. The no_cache option is somewhat documented in ResponsePolicy/DenyNoCacheRoutes.php. Rather than adding implementation specific stuff to the policy rule interface I suggest to document routing options in a central place (e.g. routing.api.php).

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented
Issue tags: +Bug Smash Initiative

The grammar error reported in the IS was fixed in Drupal 9.2.x in #2851394: Fix grammar 'a' to 'an' when necessary in Nov 2020.

It looks like the only here to determine if #7 should be a separate issue and/or if there is an issue for that already.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Regarding the wording in #7, the only places I see that use http cache are below so I suggest we leave as is and close this one out as duplicate.

./core/lib/Drupal/Core/EventSubscriber/FinishResponseSubscriber.php: // In order to support HTTP cache-revalidation, ensure that there is a
./vendor/symfony/http-kernel/HttpCache/HttpCache.php: * This setting is overridden by the stale-while-revalidate HTTP Cache-Control
./vendor/symfony/http-kernel/HttpCache/HttpCache.php: * This setting is overridden by the stale-if-error HTTP Cache-Control extension
./vendor/symfony/http-kernel/HttpCache/StoreInterface.php: * Interface implemented by HTTP cache stores.
./vendor/symfony/http-foundation/Request.php: * in the response to prevent any issues with intermediary HTTP caches.

quietone’s picture

quietone commented
Status: Active » Closed (duplicate)
Related issues: +#2851394: Fix grammar 'a' to 'an' when necessary

@chx, Thanks for reporting this issue.

@Kristen Pol, thank you for that research.

Therefore, closing as a duplicate. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thx.