Change icons for toolbar menu entries

Wouldn't changing the default cog.svg to the more generic hamburger.svg and documenting the classes generated by the modules and the toolbar_menu/css/toolbar_menu.module.css (which could include the default hover variations to it) be easier and simpler?

Hm, can we have it react to classes defined as fields on the menu link entry?

I made a quick approach, since I only needed minor changes to existing logic.
Since ToolbarMenuMenuLinkTreeManipulators is a service, I swapped it out with:

<?php

namespace Drupal\mymodule;

use Drupal\Core\DependencyInjection\ContainerBuilder;
use Drupal\Core\DependencyInjection\ServiceProviderBase;

/**
* Allows us to add our own
*/
class MymoduleServiceProvider extends ServiceProviderBase {

  /**
  * {@inheritdoc}
  */
  public function alter(ContainerBuilder $container) {
  $definition = $container->getDefinition('toolbar_menu.menu_link_tree_manipulators');
  $definition->setClass('Drupal\mymodule\ToolbarMenuTreeManipulators');
  }
}

And then using the ToolbarMenuMenuLinkTreeManipulators as base class.

Hi,

This is a patch I made to allow configuring the icons used in the toolbar. It was created from the Git version of the code.

The file css/toolbar_menu.module.css could be deleted, but I did not in case someone else is using the library declared by the module.

Regards,

I've attached a screenshot of the configuration page.

It would be nice to upload images. However, I think it should be easily used programmatically too.

I confirm #4 is doing the job...
Maybe the text under the icon path could leads to confusion:
Absolute URL path to the icon image. Leave it empty for no icon.
Regarding the Absolute URL path text: Maybe it should be like under the "logo" field (/admin/appearance/settings):
Enter a path to an icon. Drupal will look for the file relative to the Drupal root or the public file system.
With the exception that this path require a "/" at the beginning .

#4 apply with few warning on last dev:

patching file config/schema/toolbar_menu_element.schema.yml
patching file src/Entity/ToolbarMenuElement.php
Hunk #1 succeeded at 117 (offset 7 lines).
patching file src/Form/ToolbarMenuElementEditForm.php
Hunk #4 succeeded at 124 with fuzz 2.
patching file src/ToolbarMenuCssGenerator.php
patching file templates/toolbar-menu-css-icons.html.twig
patching file toolbar_menu.install
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file toolbar_menu.install.rej
patching file toolbar_menu.module
patching file toolbar_menu.services.yml

This is a very complex approach, I would rather have a symplistic solution using CSS classes as @falard suggested in #3.

I have used Font Awesome Menu Icons with some success.

#4 doesn' work in 9.x as it is using deprecated function : file_prepare_directory

Here is an updated patch

Some patch generation problem fixed.
Please review

I really have a problerm with this patch... here is the correct version.
Sorry for the wrong patches.

#14 - patch applies but is not saving the entries (urls). After saving, the icon does not appear and then when going back to edit the item the fields are blank. No errors.

Attempted to use: /core/misc/icons/bebebe/cog.svg and https://localhost/web/core/misc/icons/bebebe/cog.svg

D9.3.3
toolbar_menu 2.x-dev + #14