Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Remove unused imports in the code base
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff_3-10.txt | 2.06 KB | mondrake |
#10 | 2663256-10.patch | 10.51 KB | mondrake |
#10 | 2663256-3-test-only.patch | 10.62 KB | mondrake |
#10 | 2663256-10-test-only.patch | 2.47 KB | mondrake |
#3 | 2663256-3.patch | 8.15 KB | mondrake |
Comments
Comment #2
heykarthikwithuComment #3
mondrakeThank you @heykarthikwithu
Actually I think we can do a little bit more, see patch attached. If this passes I will commit it.
This module is pretty new and we will have need for such cleanups in the future too as new image effects get added.
Comment #4
mondrakeWrong interdiff, sorry
Comment #6
heykarthikwithuyes sure :)
Comment #7
mondrakeCommitted, thank you!
#6 ;)
Comment #9
mondrakeSorry, this broke the settings form, reverted. My fault, I removed the config factory injection which is needed by the parent constructor. This however tells us we are completely missing tests for the SettingsForm, which should then be added here.
Comment #10
mondrakeOK, fixed.
2663256-10-test-only.patch => is a test only patch (should be green) showing how SettingsForm in current HEAD is ok
2663256-3-test-only.patch => shows how the patch in #3 leads to failure of the SettingsForm (should be red)
2663256-10.patch => is the patch for review/commit (hopefully green ;))
Comment #11
mondrakeComment #12
mondrakeComment #14
mondrakeComment #15
slashrsm CreditAttribution: slashrsm as a volunteer commentedCommitted. Thank you!
Comment #17
mondrakeNo idea why, but the date of the automatic commit message is set to Feb 3 where the commit was actually on Feb 9 :( ...
Comment #18
slashrsm CreditAttribution: slashrsm as a volunteer commentedIt must be a drupal.org bug or something.