Add some basic tests for the module.

CommentFileSizeAuthor
#4 smtp-n2653386-4.patch2.31 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2653394: Integration with Maillog, +#2653398: Add option to not actually deliver emails

This would depend upon both #2653394: Integration with Maillog and #2653398: Add option to not actually deliver emails.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present

Incidentally, having a test file would stop all of the testbot failures that patches have been having lately with the module; see #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present for details.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new smtp-n2653386-4.patch2.31 KB

WIP.

wundo’s picture

wundo commented

I will commit this, to prevent all those test errors from happening, but I'd love to have some actual tests

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Cool. FYI I'm work on more :)

Status: Needs review » Needs work

The last submitted patch, 4: smtp-n2653386-4.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I added some tests to #2653394: Integration with Maillog to confirm that email delivery (or at least storage of emails) worked as intended.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2651788: Plan for SMTP 7.x-1.4 release

I also added tests to #1847678: SMTP server failure, no retry?.

What other tests would be needed?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

The tests are currently failing. Lets fix them.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

HEAD was broken by #2653394: Integration with Maillog - two files weren't added ;)

wundo’s picture

wundo commented
Status: Needs work » Needs review

Fixed

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Cool.

Are there any other tests that should be added?

wundo’s picture

wundo commented
Status: Needs review » Fixed

Not that I can think of now, I will mark this as fixed and we can create new issues for new tests as needed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.