The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Add some basic tests for the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | smtp-n2653386-4.patch | 2.31 KB | damienmckenna |
The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Add some basic tests for the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | smtp-n2653386-4.patch | 2.31 KB | damienmckenna |
Comments
Comment #2
damienmckennaThis would depend upon both #2653394: Integration with Maillog and #2653398: Add option to not actually deliver emails.
Comment #3
damienmckennaIncidentally, having a test file would stop all of the testbot failures that patches have been having lately with the module; see #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present for details.
Comment #4
damienmckennaWIP.
Comment #5
wundo commentedI will commit this, to prevent all those test errors from happening, but I'd love to have some actual tests
Comment #7
damienmckennaCool. FYI I'm work on more :)
Comment #10
damienmckennaI added some tests to #2653394: Integration with Maillog to confirm that email delivery (or at least storage of emails) worked as intended.
Comment #11
damienmckennaI also added tests to #1847678: SMTP server failure, no retry?.
What other tests would be needed?
Comment #12
damienmckennaComment #13
damienmckennaThe tests are currently failing. Lets fix them.
Comment #14
damienmckennaHEAD was broken by #2653394: Integration with Maillog - two files weren't added ;)
Comment #15
wundo commentedFixed
Comment #16
damienmckennaCool.
Are there any other tests that should be added?
Comment #17
wundo commentedNot that I can think of now, I will mark this as fixed and we can create new issues for new tests as needed