If autocomplete deluxe module is enabled, the red borders for a missing node reference are missing. The form field error is missing as indicator. I'm using seven as admin theme.

CommentFileSizeAuthor
#7 Adminimal Theme After Patch.png18.81 KBkrina.addweb
#7 Seven Theme Result After Patch.png8.24 KBkrina.addweb
#7 Seven Theme Before PAtch.png41.7 KBkrina.addweb
#7 Adminimal Theme Result Before Patch.png6.26 KBkrina.addweb
#5 autocomplete_deluxe-no_red_border-2650228-5.patch529 bytesmibfire
#4 autocomplete_deluxe-no_red_border-2650228-4.patch523 bytesmibfire
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jepSter created an issue. See original summary.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku commented
Issue summary: View changes
seren10pity13’s picture

seren10pity13 CreditAttribution: seren10pity13 commented

Same problem here with Adminimal theme for a required autocomplete field.

I've been digging a little bit into it, but I really don't understand why the error class is missing in the html form, and where/when it should be added.
Actually, the stylesheet don't seems to have an error class either.

mibfire’s picture

mibfire CreditAttribution: mibfire commented
FileSize
autocomplete_deluxe-no_red_border-2650228-4.patch523 bytes

I fixed this.

mibfire’s picture

mibfire CreditAttribution: mibfire commented
FileSize
autocomplete_deluxe-no_red_border-2650228-5.patch529 bytes

.error class was missing. I fixed.

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented
Status: Active » Needs review
krina.addweb’s picture

krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community
FileSize
Adminimal Theme Result Before Patch.png6.26 KB
Seven Theme Before PAtch.png41.7 KB
Seven Theme Result After Patch.png8.24 KB
Adminimal Theme After Patch.png18.81 KB

@mibfire, Thanks for the patch corrections, it works well for both the theme Adminimal theme & seven theme. I checked this patch using simplytest.me & attached the screenshots for the same.

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented
Status: Reviewed & tested by the community » Needs work

@krina.addweb and @mibfire - I'm really mystified by this patch and the results you are both getting.

#5 does not work for me on the current dev version of the code, and I don't see how it could have for any code released in the past couple of years - I see no validation function for the "single" mode scenario (there is one for "multiple" mode), and no code to cause the required class to be added to the textfield. Do you see those things in your version of the code?

mibfire’s picture

mibfire CreditAttribution: mibfire commented

@LNakamura

I don't understand what you don't understand. Install the Adminimal theme download this module, make the field required and save the node without filling the field. You can see there is no red border around the field.

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented

Hi, @mibfire - the problem (lack of a red border) is not the problem :-) I'm mystified by the patch, which doesn't work for me.