[D7] Bootstrap Sass

hi @wrender

Thanks for your contribution.

Please add git clone command in your issue eg-: 
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/username/1234567

thanks

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxwrender2627564git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Spamming is not the way to get your project promoted. If anything it show you probably shouldnt have the ability to promote.

You can check out the automated review here
http://pareview.sh/pareview/httpgitdrupalorgsandboxwrender2627564git
Click on repeat review and if the box is blank use - http://git.drupal.org/sandbox/wrender/2627564.git

You have a lot of errors there so sort them before changing to needs review and if you make any changes run that review again.

I think your readme file needs some work. It needs breaking up a bit and maybe add numbers. Also it seems to be written as a reminder sheet for someone who knows what they are doing and not actual instructions. For example what is grunt init and where do I run it from? imagine I'm trying to make my first Drupal theme having first been introduced to Drupal a week ago.

Minor coding standard errors and readme improvements are surely not application blockers, anything else that you found or should this be RTBC instead?

No they are non-blocking but got cut short and hadn't finished testing,

A few more notes
i have a lot of themes installed I was looking under B for Bootstrap SASS Found it under "StarterKit Bootstrap with SASS"
Need some more consistent naming conventions.
Also the installation instructions on the sandbox project page do not match the readme file

Most critically though I can't get it working using your instructions.
I got several errors when running npm install. Forgot to check if grunt was installed etc. so had to go back and start again but still got a load of errors? Should I be root? I tried to grab the log file but its not where it says it should be. Tried installing as root. Still tons of errors. I saved the command line output though, attached.

Ok something rather odd I just noticed. This is after I removed bootstrap_sass. My test site is now a fresh install with the youtube_import module on it. I was checking the logs and noticed a page not found error for

http://mysite.co.uk/sites/all/themes/bootstrap_sass_starterkit/node_modu...

Referres is mysite.co.uk./user/password

If I open this while logged into my site it does open a link. I'm now wondering what did this do to my webserver that it's serving files that are not there.

And also why am I getting external requests for those files?

I deleted the site database and the website files and did a fresh install of drupal. I figred out why the files were still there. It was a quirk of the browser cache. For some reason it was actually serving the files from the browser cache when I was logged into the site as admin but not when logged out. Clearing the browser cache solved that but I still find it odd that I was getting external requests for those files. Can you think of any reason for that?

Ah I never thought of the version. I didnt have nodejs or npm installed on my server so i googled it and ran the installer. Figured since 4.4 was up on the website as stable i assumed id get that version

I'll update and try again

No I don't think so either. It just really threw me that it had the files cached for admin but not for anon. I was setup on a vanilla Drupal 7.43 With minimal install. AS soon as i get chance to reset my test site I'll test again

Just tried again and got

    Notice: Undefined index: bootstrap_sass in drupal_theme_initialize() (line 100 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _drupal_theme_initialize() (line 146 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _theme_load_registry() (line 335 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _theme_load_registry() (line 319 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _theme_build_registry() (line 713 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _theme_build_registry() (line 713 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _theme_build_registry() (line 713 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in _theme_save_registry() (line 343 of /var/www/includes/theme.inc).
    Notice: Undefined index: bootstrap_sass in theme_get_setting() (line 1439 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in theme_get_setting() (line 1476 of /var/www/includes/theme.inc).
    Notice: Trying to get property of non-object in theme_get_setting() (line 1486 of /var/www/includes/theme.inc).

Then getting connection reset and cant access the site unless i remove the theme

Yes I have bottstrap installed.

I'm also getting the following error in my apache error log.
[Tue Mar 29 13:27:49.106325 2016] [core:notice] [pid 1401] AH00051: child pid 6444 exit signal Segmentation fault (11), possible coredump in /etc/apache2

@wrender, found these below issues.

1. It seems that template.php file is not being used as it appears empty. Is it serving some purpose?
2. Both gruntfile.j & gulpfile.js do not follow File-closure mode in JavaScript coding standards - https://www.drupal.org/node/172169:

All JavaScript code MUST be declared inside a closure wrapping the whole file and this closure MUST be in strict mode as below:

/**
 * @file
 */
(function () {

  "use strict";

  // All the JavaScript for this file.

})();

Please fix these.

(1) In that case, it makes sense to drop a comment in the file for it being empty.

(2) Not sure about that.. would like some one to look into (2) argument.. leaving status in Needs review though..