I found the module is not working when using tokens in meta fields. Have checked in the code but there is no token_replace concept.

One more thing, whenever i am trying to uninstall the module it is asking to delete views where i used this formatter. Not sure why should it deletes the views, I mean if the module is dependent on other module, does this the mean it has to delete parent module data also?

CommentFileSizeAuthor
#7 2634474-7.patch1.12 KBheykarthikwithu

Comments

krknth created an issue. See original summary.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

@krknth,

Thanks for reporting the issue , we should definitely take care of this on next release.

It asking you to delete the views , because you are using the field formatter which provided by the module on your views. At any case, it should not be delete the parent module data, that means here meta tag, Is it really deleting data provide by meta tag module ? In that please report an another issue , will take care of that also.

Thank you so much for contributing to the module.

neerajskydiver’s picture

neerajskydiver commented
Title: Not working with tokens & views getting deleted while uninstall » Not working with tokens. Views getting deleted during uninstall
Issue summary: View changes
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

1.

Not working with token

Tokens module is under development not having a stable release. So, this feature will be implemented once token module is released.
https://www.drupal.org/project/token
https://www.drupal.org/project/token_filter

2.

Views getting deleted during uninstall

Seems drupal by default deleting the dependent Configurations, while uninstalling the module.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Active » Postponed (maintainer needs more info)
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: Unassigned » heykarthikwithu
Status: Postponed (maintainer needs more info) » Needs work
heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented
Assigned: heykarthikwithu » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2634474-7.patch1.12 KB

Instead of depending on token module, we can use Drupal core token system to work this out.
This patch works based on core token system.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Needs review » Fixed

Looks fine , As of now the node tokens are working.

  • rakesh.gectcr committed f4f8f4f on 8.x-1.x 
    Issue #2634474 by heykarthikwithu, rakesh.gectcr, krknth, neerajskydiver...
krknth’s picture

krknth commented

@rakesh : small correctoin ;) . It will work for any entity tokens, Not only node.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

@krknth, It is not working with user token.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.