Follow-up to #2621024: Wrong CSS positioning of form elements block "% Off"-selection under "Choose Offer Type"

Ran into CSS conflicts where the fields overlap the radio buttons.

Moved things into fieldset also to remove TODOs

CommentFileSizeAuthor
#10 interdiff.txt1.44 KBjoelpittet
#10 wrong_css_positioning-2632120-10.patch13.64 KBjoelpittet
#8 interdiff.txt12.15 KBjoelpittet
#8 wrong_css_positioning-2632120-8.patch14.22 KBjoelpittet
#6 Edit__5_off_products___Site-Install.png33.23 KBjoelpittet
#5 interdiff.txt11.51 KBjoelpittet
#5 wrong_css_positioning-2632120-5.patch13.47 KBjoelpittet
#2 wrong_css_positioning-2632120-2.patch5.98 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new wrong_css_positioning-2632120-2.patch5.98 KB
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: wrong_css_positioning-2632120-2.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new wrong_css_positioning-2632120-5.patch13.47 KB
new interdiff.txt11.51 KB

Likely won't fix tests but is cleaner.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Wrong CSS positioning of form elements block "% Off"-selection under "Choose Offer Type" » Wrong CSS positioning of form elements over the offer type radios
Issue summary: View changes
StatusFileSize
new Edit__5_off_products___Site-Install.png33.23 KB

Status: Needs review » Needs work

The last submitted patch, 5: wrong_css_positioning-2632120-5.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
StatusFileSize
new wrong_css_positioning-2632120-8.patch14.22 KB
new interdiff.txt12.15 KB

Ok fixed the values, kinda. Let's see if the UI works.

Status: Needs review » Needs work

The last submitted patch, 8: wrong_css_positioning-2632120-8.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new wrong_css_positioning-2632120-10.patch13.64 KB
new interdiff.txt1.44 KB

Ok well that was not bright, anyways, doctored the #parents array and booya. As you like to see I like to fail in the open;)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Committed this to -dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.