diff --git a/css/commerce_discount.css b/css/commerce_discount.css index 734ac98..c1fbb04 100644 --- a/css/commerce_discount.css +++ b/css/commerce_discount.css @@ -119,7 +119,7 @@ * Choose offer type block. */ .field-name-commerce-discount-offer { - border: none; + border: 0; margin: 0; padding: 0; } @@ -128,82 +128,76 @@ display: table; clear: both; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type label { - clear: both; - border-bottom: 1px solid #ccc; +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios { + padding-left: 0; + padding-right: 0; } -[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type label { - padding-left: 5px; +[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios { + float: left; + margin-right: 20px; + padding-right: 20px; + border-right: 1px dotted #ccc; } -[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type label { - padding-right: 5px; +[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios { + float: right; + margin-left: 20px; + padding-left: 20px; + border-left: 1px dotted #ccc; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios { clear: both; - background-color: transparent; margin: 10px; - padding: 4px 0; + padding: 0; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item { color: black; border-radius: 5px; margin-bottom: 5px; padding: 5px; } -[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item { +[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item { margin-right: 20px; } -[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item { +[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item { margin-left: 20px; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item:hover { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item:hover { background-color: #f6f6f6; cursor: pointer; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item:hover label { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item:hover label { cursor: pointer; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item input { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item input { display: inline; } -[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios { - float: left; - margin-right: 20px; - padding-right: 20px; - border-right: 1px dotted #ccc; -} -[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios { - float: right; - margin-left: 20px; - padding-left: 20px; - border-left: 1px dotted #ccc; -} -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item.selected { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item.selected { background-color: #eee; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios .form-item .ajax-progress { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios .form-item .ajax-progress { display: none; } -.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios label { +.field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios label { border-bottom: 0; } -[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios label { +[dir="ltr"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios label { padding-left: 0; } -[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type .form-radios label { +[dir="rtl"] .field-name-commerce-discount-offer .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios .form-radios label { padding-right: 0; } -.field-name-commerce-discount-offer #edit-commerce-discount-fields-commerce-discount-offer-und-form:after { +.field-name-commerce-discount-offer .commerce-offer-type-wrapper > .fieldset-wrapper:after { content: ""; display: table; clear: both; } -[dir="ltr"] .field-name-commerce-discount-offer .commerce-offer-fields-wrapper, [dir="ltr"] -.field-name-commerce-discount-offer .form-type-radios > .form-radios { +.field-name-commerce-discount-offer .commerce-offer-fields-wrapper { + padding: 0; +} +[dir="ltr"] .field-name-commerce-discount-offer .commerce-offer-fields-wrapper { float: left; } -[dir="rtl"] .field-name-commerce-discount-offer .commerce-offer-fields-wrapper, [dir="rtl"] -.field-name-commerce-discount-offer .form-type-radios > .form-radios { +[dir="rtl"] .field-name-commerce-discount-offer .commerce-offer-fields-wrapper { float: right; } .field-name-commerce-discount-offer .form-wrapper .form-wrapper .form-item { @@ -324,18 +318,18 @@ margin-right: 10px; } .commerce-discount-usage .field-type-number-integer .form-disabled input { - border: none; - background: none; + border: 0; + background-color: transparent; } /** * Overview table. */ .view-commerce-discount-overview .views-table { - border: none; + border: 0; } .view-commerce-discount-overview .views-table tr, .view-commerce-discount-overview .views-table td { - border: none; + border: 0; } .view-commerce-discount-overview .views-table th { text-transform: none; diff --git a/includes/commerce_discount_offer.inline_entity_form.inc b/includes/commerce_discount_offer.inline_entity_form.inc index efe2422..d2e721a 100644 --- a/includes/commerce_discount_offer.inline_entity_form.inc +++ b/includes/commerce_discount_offer.inline_entity_form.inc @@ -63,16 +63,19 @@ class CommerceDiscountOfferInlineEntityFormController extends EntityInlineEntity '#weight' => 2, ); - // Move fields onto container. + // Transfer field elements onto fields container. foreach (element_children($entity_form) as $key) { $fields_wrapper[$key] = $entity_form[$key]; unset($entity_form[$key]); } + // Set the fields container back on the form. + $entity_form['fields'] = $fields_wrapper; - // Add ratios. + // Add offer type options. $entity_form['type'] = array( '#type' => 'radios', '#title' => t('Choose offer type'), + '#title_display' => 'invisible', '#options' => $offer_types, '#required' => FALSE, '#default_value' => $offer->type, @@ -80,10 +83,14 @@ class CommerceDiscountOfferInlineEntityFormController extends EntityInlineEntity 'callback' => 'inline_entity_form_get_element', 'wrapper' => 'inline-entity-form-' . $ief_id, ), + '#wrapper_attributes' => array('class' => array('form-type-radios--offer-type')), '#weight' => 1, ); - $entity_form['fields'] = $fields_wrapper; + // Add wrapper class for CSS to avoid form item collisions. + $entity_form['#attributes']['class'] = array('commerce-offer-type-wrapper'); + $entity_form['#type'] = 'fieldset'; + $entity_form['#title'] = t('Choose offer type'); return $entity_form; } diff --git a/sass/commerce_discount.scss b/sass/commerce_discount.scss index 1125b2d..e97ae88 100644 --- a/sass/commerce_discount.scss +++ b/sass/commerce_discount.scss @@ -114,44 +114,32 @@ // Help with floaties inside. @include clearfix; - border: none; + border: 0; margin: 0; padding: 0; - .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type { - label { - clear: both; // Ensure it pushes the right side below when it's floating. - border-bottom: 1px solid $gray2; - - [dir="ltr"] & { - padding-left: 5px; - } + // Offer type options. + .form-item-commerce-discount-fields-commerce-discount-offer-und-form-type.form-type-radios { + padding-left: 0; + padding-right: 0; + [dir="ltr"] & { + float: left; + margin-right: 20px; + padding-right: 20px; + border-right: 1px dotted $gray2; + } - [dir="rtl"] & { - padding-right: 5px; - } + [dir="rtl"] & { + float: right; + margin-left: 20px; + padding-left: 20px; + border-left: 1px dotted $gray2; } .form-radios { @include radio-buttons; - - background-color: transparent; margin: 10px; - padding: 4px 0; - - [dir="ltr"] & { - float: left; - margin-right: 20px; - padding-right: 20px; - border-right: 1px dotted $gray2; - } - - [dir="rtl"] & { - float: right; - margin-left: 20px; - padding-left: 20px; - border-left: 1px dotted $gray2; - } + padding: 0; .form-item { &.selected { @@ -177,14 +165,14 @@ } } - // Targetting the ID because there is no classes on the item wrapping. - #edit-commerce-discount-fields-commerce-discount-offer-und-form { + // Avoid collision with fields below. + .commerce-offer-type-wrapper > .fieldset-wrapper { @include clearfix; } // The two columns for the offer type. - .commerce-offer-fields-wrapper, - .form-type-radios > .form-radios { + .commerce-offer-fields-wrapper { + padding: 0; [dir="ltr"] & { float: left; } @@ -353,8 +341,8 @@ } .form-disabled input { - border: none; - background: none; + border: 0; + background-color: transparent; } } } @@ -364,10 +352,10 @@ */ .view-commerce-discount-overview { .views-table { - border: none; + border: 0; tr, td { - border: none; + border: 0; } th {