Widget: HTML5 and map input/confirmation

Thanks Jochen for your answers!

I finally found some time to try to modify Geolocation Google Geocoder to include the HTML5 browser geolocation in the google geocoder widget and it seems to work pretty well on my side. Please bear with me, this is my first ever patch, I hope it will be useful but it surely needs review!

After thinking about it, I went for something a bit different and simpler than what I described earlier. Upon loading the form containing the widget, if no location is set (so only on create form and not edit form), the user is prompted to share her browser's position. When the location is shared, the marker is set, a circle with the accuracy radius is drawn and the map is set to the position, zooming in to show the accuracy radius. Values for lat and lng are passed to the hidden form. If needed, the marker can be set somewhere else as usual with a click, and the circle disappears. The clear button also works as usual.

This feature works pretty well when a user is contributing data on scene with a smartphone or around his place, but I guess some use cases for the module would imply users contributing data for some remote places, in which case it wouldn't be that practical to deny the getCurrentPosition before using search. I'm thinking this should be an option/configuration for the module, in order to keep the interface clean. If that's not possible, we could also go back to a getCurrentPosition button and no call on page load, like in the previous mockup, but it's adding a tap on a small button for a smartphone user.

Thanks for your time!

Thanks for the tip! Hope it's ok now!

Thanks Jochen, I'll keep that in mind for next time!

I'm back with some improvements on this feature... It looks alright (see screen capture) and works pretty well for me, however, this patch probably has a lot of issues, which I tried to document... Keep in mind I consider myself a bad coder and it's mostly the result of trials and errors! But I'd really like to give back and hope somebody can have a look and show me how it should have been done!

To name two of the main shortcomings:

• getCurrentPosition code is replicated because I couldn't manage to set it as global and to call it from the button
• when setting a marker by hand and then using the HTML5 geolocation, the initial marker is not deleted

One more general question: I was assuming that geolocation.js should contain features needed for displaying the field and that geolocation-widget-googlegeocoder.js would contain the widget related features, but it seems like it's not really the case. For example, buttons and search are in geolocation.js but used in the widget. Is there an explanation for that or is it waiting to be refactored some day?

Thanks a lot for your patience!

Thanks for your tests and new patch Ignacio!

That's weird for the getlocation button, it worked well for me. I'll give a try at your patch when I find a bit more time.

Any ideas on the "code replication" problem described in #20? There has to be a better way and it seems like something we should address before considering merging this feature! Thanks again!