Missing D7 functionality in Geocoder D8 "Homing" button.

Hi Christian,

Do you envision these "missing" features as alternative settings or as a replacement for the current dev feature? It seems like there could be 2 different modes:

• offer the user to click on the button to help centering the map around her and let her set the marker
• get the location from the browser and set it as the marker, and allow for further adjusting

In my use case, I want to set the location by default, as soon as possible and without requiring the user to click/tap to use it (of course, the user can discard the feature by not sharing his location in the browser UI), to give her a visual indication of the accuracy of the position (a disc on the map) and allow her to call the position again (to get a better accuracy) or to set the right position (the disc disappears when the marker is moved by the user or when the marker is set from search). This seems to cover the described features pretty well.

I got this to work through this old patch, you can try it here.

Do you think these two modes could coexist through an "autolocate" or "autofill with user position" option in the form display settings for the content type? Thanks for your insight!

options sound great. every site will have its own requirements.

- center on pageload yes/no
- show center on click button yes/no
- show accuracy yes/no
- show marker yes/no
- allow readjusting the marker yes/no
- reverse geocode the marker/center and show closest address info yes/no
- autozoom depending on accuracy yes/no

Regarding the "allow readjusting the marker" feature - and as you may already know - it appears that the Geolocation OSM sub-module has this functionality in place. While realizing that the code may not be swappable, I thought it worth noting in case it helps this module's maintainers move this (awesome) module forward.

So we could update the description of this issue and tick off some of the missing features?

I tested both modes in the latest dev version (centering and setting value) and found 2 issues with the latter mode:

• the marker is set, but the hidden field values are left untouched, which is really counterintuitive, given that setting the marker usually sets/update the value in this widget. Fixed that by setting Drupal.geolocation.geocoderWidget.setHiddenInputFields with the position.coords...
• The locate button remains in the centering only mode even if the setting value mode is chose. Setting the marker and then clicking on locate button has no effect on the marker. Edge use case I guess, but still can happen...

The following patch also include enhancements for the setting value mode: if using HTML5 location to set the marker, a circle representing the accuracy of HTML5 location is drawn and the map viewport is bound to it, so that the user can tell if the position can be trusted and can adjust it easily. The circle disappears when clearing the geolocation values or when moving the marker manually.

I think this on top of the latest dev version would solve the remaining points listed in the issue (if backported to D7 version).

Thanks for your quick feedback!

The "circle magic" is in geolocation-geocoder to apply on locate button click and in geolocation-widget-googlegeocoder to apply on load. I'm sure there's a better way to avoid code duplication and I understand the logic behind separating Google from the geocoder JS and I'm looking forward to alternative maps, but it looks like geolocation-geocoder is still full of Google Maps API features. I guess geolocation-geocoder should call a getAccuracy function on locate button click, the function being declared in geolocation-widget-googlegeocoder for google maps and/or in another future js with the same feature for mapbox or leaflet, is that it?

I guess I should seriously learn to code for that, I gave it a run through my usual observation/trial/error process and couldn't get it to work, really sorry about that!

Hi Christian,
When we can expect a release with these new features. I am also looking for the same kind of functionality, where marker location should be captured automatically and user allow to change it.
Thanks

Hey Christian,

I realized that one of your recent commits had "cleaned" geolocation-geocoder.js from Google Maps references, so it was much easier for me to put the "circle magic" in a cleaner patch. Thanks for the help on that!

I've tested it on the latest dev with different settings and use cases, and it works well for me.

Thanks Christian, sounds good, especially with the zoom trick ;-) !

A few remarks after testing, with "Will use client location automatically by default" and "Will set client location marker automatically by default" set on my widget:

• It seems that these automatic settings are not working anymore: I get the centering/zooming on map load, but the marker is not set as it was a few commits ago. When using the locate button, it is set.
• I occasionally got this error in Firefox's console: TypeError: Drupal.geolocation.drawAccuracyIndicator is not a function geolocation-widget-googlegeocoder.js:172:15 , but I can't seem to reproduce it.

Humm, sorry if I haven't been clear. I agree about the change for default value from widget to field and the default value not setting the marker/inputs anymore, but we have 2 modes for the setting, as described in #3 and controlled by these settings in t:

• Automatically use client location, when no value is set
• Automatically set marker to client location as well

I have both settings on, and the resulting behaviour is what I expect from the first option alone. In fact, I can't see a difference of behaviour whether "Automatically set marker to client location as well" is checked or not. Am I missing something?

Can't see the js error so it was probably some cache issue.