Steps to reproduce :
1. Log in to the site
2. Click on Edit menu in the admin menu.
3. The pencil icon overlaps the "Log out" link title.

Adding screen-shots and patch for the same.

CommentFileSizeAuthor
#46 Before-LTR.png61.94 KBShubham Sharma 77
#46 Before-RTL.png60.94 KBShubham Sharma 77
#46 After-LTR-patch.png60.85 KBShubham Sharma 77
#46 After-RTL-patch.png62.51 KBShubham Sharma 77
#44 contextual_links_toggle-2630150-44.patch2.39 KBdruprad
#41 interdiff_40-41.txt1.13 KBranjith_kumar_k_u
#41 2630150-41.patch2.39 KBranjith_kumar_k_u
#40 2630150-40.patch2.41 KBajaypratapsingh
#22 Screen Shot 2016-08-04 at 6.09.37 PM.png11.36 KBiamanupmenon
#21 icon-pen.png26.81 KBmanjit.singh
#19 interdiff.txt1.4 KBkostyashupenko
#19 contextual_links_toggle-2630150-19.patch2.33 KBkostyashupenko
#19 contextual_expanded.png8.78 KBkostyashupenko
#19 contextual.png6.17 KBkostyashupenko
#17 Screenshot from 2016-06-15 17:44:02.png13.81 KBmanjit.singh
#17 Screenshot from 2016-06-15 17:43:47.png5.9 KBmanjit.singh
#17 Screenshot from 2016-06-15 17:43:34.png10.43 KBmanjit.singh
#16 edit-pencil.png15.49 KBjoginderpc
#13 pencil.png31.72 KBKumar Kundan
#9 Screen Shot 2016-01-30 at 1.11.01 pm.png27.18 KBsoumyajit.basu
#8 Drupal_core-hides_Log_out_link-2630150-8.patch1.63 KBvivek.addweb
#8 after.jpg52.94 KBvivek.addweb
#8 before.jpg52.89 KBvivek.addweb
#5 Edit_button_hides_log_out_link_bartik_theme-2630150-4.patch815 bytesvivek.addweb
#4 Edit_button_hides_log_out_link_bartik_theme-2630150-4.patch621 bytesvivek.addweb
logout_link_before.png102.35 KBAnuj786

Comments

Anuj786 created an issue. See original summary.

heykarthikwithu’s picture

heykarthikwithu
Primary language English
Location Bengaluru 🌍
commented

@Anuj786, the pencil mark is link to edit the block.
If a particular user is having the permission to configure blocks, then he will be able to see this (It works like this only) :).

Anuj786’s picture

Anuj786 commented

@heykarthikwithu

yes i know, but this icon overlaps the "Log out" on hover or click on edit and this needs too be fixed.

vivek.addweb’s picture

vivek.addweb commented
StatusFileSize
new Edit_button_hides_log_out_link_bartik_theme-2630150-4.patch621 bytes

Find the attachment of the patch. Changed 'Edit' button position.

vivek.addweb’s picture

vivek.addweb commented
StatusFileSize
new Edit_button_hides_log_out_link_bartik_theme-2630150-4.patch815 bytes

Find the attached patch. Changed 'Edit' button position.

Snehal Brahmbhatt’s picture

Snehal Brahmbhatt commented
Status: Active » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Edit button hides "Log out" link Bartik Theme » Contextual links toggle hides "Log out" link
Version: 8.0.0 » 8.0.x-dev
Component: Bartik theme » contextual.module
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work
Issue tags: +CSS

This is not remotely ready.

Please do proper testing of a patch before marking it RTBC. (The lack of proper testing looks especially strange/suspicious since you're working for the same company.)

  1. This updated the CSS in stable but not in the contextual module itself.
  2. I'm not seeing any before/after screenshots.
  3. I strongly suspect this solved one case at the cost of all others: I suspect this causes regressions elsewhere.

Not to mention this is not at all Bartik-specific.

vivek.addweb’s picture

vivek.addweb commented
StatusFileSize
new before.jpg52.89 KB
new after.jpg52.94 KB
new Drupal_core-hides_Log_out_link-2630150-8.patch1.63 KB

@Wim: Thanks for guiding me here.

1. I have updated the CSS in contextual module as well. The CSS needs to be kept in stable theme as core theme uses stable contextual CSS.
2. Attached before/after screenshots for reference.

Please check once and do the needful actions.

soumyajit.basu’s picture

soumyajit.basu commented
StatusFileSize
new Screen Shot 2016-01-30 at 1.11.01 pm.png27.18 KB

The pencil icon is now not overlapping the log out link. Reviewed. Please check the screenshot

soumyajit.basu’s picture

soumyajit.basu commented
Status: Needs work » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

That fixes it for Bartik, but is there an issue with Stable, and does this fix it there if so? Also what about RTL?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Kumar Kundan’s picture

Kumar Kundan commented
Version: 8.1.x-dev » 8.1.0-rc1
StatusFileSize
new pencil.png31.72 KB

Patch working fine!!!!!!!!!

markdorison’s picture

markdorison
he/him
commented
Version: 8.1.0-rc1 » 8.1.x-dev
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Issue tags: +Needs manual testing, +need screenshots, +Contextual links
joginderpc’s picture

joginderpc
Location Mohali
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing, -need screenshots
StatusFileSize
new edit-pencil.png15.49 KB

Manual tested on newer version 8.1.x and the patch is working fine as screen shot attached. Moving this issue to next step.

pencil not overlapping after patch applying.

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Version: 8.1.x-dev » 8.2.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +RTL
StatusFileSize
new Screenshot from 2016-06-15 17:43:34.png10.43 KB
new Screenshot from 2016-06-15 17:43:47.png5.9 KB
new Screenshot from 2016-06-15 17:44:02.png13.81 KB

Thanks @joginderpc for testing but i think we have to look into rtl also. there are some regression issues that we have to fixed. Please check the screenshot.

rb

rb

rb

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: Unassigned » kostyashupenko
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Assigned: kostyashupenko » Unassigned
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new contextual.png6.17 KB
new contextual_expanded.png8.78 KB
new contextual_links_toggle-2630150-19.patch2.33 KB
new interdiff.txt1.4 KB

Hm, from what i've seen. All changes are kept it stable folder. But i'm not sure that it's correct. I need opinion of someone. But in included css files i didnt see anything that related with contextual and bartik/seven. Only stable styles there. So accordance with #8 patch i have added few changes in stable folder and modules folder for contextual only for RTL.
I think we need a detailed description of the contextual issue - how it is in bartik/seven and what exactly we should do. Because as i see we still have some problems with it. For example if you'll resize your window to ~1200px of width - you will see unnecessary horizontal scroll. I'm not sure that it's expected. And what about mobiles? Anyway as i said we need a detailed description of this task.
For now patch here. It's based on #8. Screens attached.
contextual_2.png
contextual_expanded.png

joginderpc’s picture

joginderpc
Location Mohali
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -RTL

@kostyashupenko seems fine i had tested this manually for both LTR and RTL, forwarding this to next step.

manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +DevDaysMilan
StatusFileSize
new icon-pen.png26.81 KB

I have not found any issues though but dont know it seems like it had resolved forcefully. Please check the before and after screenshots for other pen icons on the site.

pen

iamanupmenon’s picture

iamanupmenon commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2016-08-04 at 6.09.37 PM.png11.36 KB

The latest patch i tested
it looks good
Image

iamanupmenon’s picture

iamanupmenon commented
star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Based on #21 I don't think this is ready, that looks like a visual regression to me.

darketaine’s picture

darketaine commented
Status: Needs review » Needs work

Maybe a solution would be to focus on the position of the menu (My account / Logout links) and not the contextual links, as changing their position creates many problems in all other places they appear.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

selfirian’s picture

selfirian commented

I agree with @darketaine it seems to be smarter to add some right padding/margin to the menu so that there's room for the contextual link icon, since it always sit's in the same spot this should be accounted for in menu's for logged in users.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Needs reroll, +Bug Smash Initiative

Is this a duplicate of #2355501: Contextual link triggers cover too much of small contextual regions or vice-versa?

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ajaypratapsingh’s picture

ajaypratapsingh commented
Status: Needs work » Needs review
StatusFileSize
new 2630150-40.patch2.41 KB

rerolled patch #19

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new 2630150-41.patch2.39 KB
new interdiff_40-41.txt1.13 KB

Status: Needs review » Needs work

The last submitted patch, 41: 2630150-41.patch, failed testing. View results

druprad’s picture

druprad
Primary language English
commented
Assigned: Unassigned » druprad
druprad’s picture

druprad
Primary language English
commented
Assigned: druprad » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new contextual_links_toggle-2630150-44.patch2.39 KB

Reroll the patch #19 with Drupal 9.5.x

deepalij’s picture

deepalij commented
Assigned: Unassigned » deepalij
Shubham Sharma 77’s picture

Shubham Sharma 77 commented
Assigned: deepalij » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After-RTL-patch.png62.51 KB
new After-LTR-patch.png60.85 KB
new Before-RTL.png60.94 KB
new Before-LTR.png61.94 KB

Applied patch #44 applied successfully in drupal-9.5.x-dev for both LTR and RTL, forwarding this to next step.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 44: contextual_links_toggle-2630150-44.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.