Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
To make urls more readable, we should be able to change an alias for a facet.
Comment | File | Size | Author |
---|---|---|---|
#10 | create_settings_for_the-2624410-10.patch | 9.45 KB | borisson_ |
Comments
Comment #2
borisson_How bout this?
Comment #3
Nick_vhWhich URL standards? This help text does not add much without more context. If we will url encode that anyway, what does it even matter?
Don't we need to xss filter the url parameter as well?
an array is required?
url encoding :( Always ugly, but understandable.
Comment #4
borisson_#3.1 - Removing the description looks like the best thing to do.
#3.2 - Yes, we should. I'll have a look at how the validation of the path widget works.
#3.3 - This is only in the test, but yeah; the
\Symfony\Component\HttpFoundation\ParameterBag::set
method needs a key and a value.#3.4 - Nothing to do about that.
Comment #5
borisson_I did the Xss in the entity, for better results.
Comment #6
StryKaizerI dont think we need to do an xss filter on this field (and if we do, we shouldnt do it in the set-method, Drupal always filters when requesting data, not when setting data)
I might be wrong though, can somebody give an example on how this can be abused?
url_parameter: can we use url_alias instead? D7 Pretty paths used this too, and I think its a better name ;)
Comment #7
borisson_Changed to url_alias and removed the xss filtering.
Comment #8
borisson_Needed a reroll because of namespace changes.
Comment #9
borisson_Needed another reroll.
Comment #10
borisson_Added a test, tests are good.
Comment #11
aspilicious CreditAttribution: aspilicious commentedIf you open a dev release you can test your patches, makes it easier...
Comment #12
borisson_@aspilicious: true, but the tests still require search api, while the module doesn't, per se. In the travis tests, we explicitly enable search_api before executing tests.
- http://cgit.drupalcode.org/facets/tree/.travis.yml
Comment #13
aspilicious CreditAttribution: aspilicious commentedThere is a workaround for that, I do the same for field_group in DS. Create a fake test module with a dependency on search_API nothibg else. Commit and wait 24 hours. Then testbot will not fail anymore. :)
Look at the commit log for DS if you need an example.
Comment #15
borisson_