Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
# Summary
DownloadFile
# Project URL
https://www.drupal.org/project/download_file
# Where is the code?
https://www.drupal.org/sandbox/bnjmnm/2872204
# Estimated completion date
Mid to Late May 2017
# Dependencies
none
# Who's doing the port?
Bnjmnm
# What help do they need?
Review from a more experienced D8 dev would be great.
# D8 roadmap
No maps needed, just going to get this farily-straightforward module out to yall.
# Background and reference information
I came on as a maintainer for Download File a few months ago to help address an unresolved security issue. It seemed like a good candidate for my first D8 module port.dru
Comments
Comment #2
dpiThere is no code...
Comment #3
bnjmnmI have a functional (but with currently only one formatter) version in a sandbox. Aiming to have it done in the next week or two.
https://www.drupal.org/sandbox/bnjmnm/2872204
Comment #4
bnjmnmComment #5
bnjmnmComment #6
gngn CreditAttribution: gngn at Computer Manufaktur GmbH commentedHi. thanx for the "headstart" :)
I worked on the module, added some stuff, applied code guidelines etc.
Where can I put my code?
Here? In the issues of the sandbox?
Until now I just added patches...
Comment #7
bnjmnmNice! I created an 8.x dev branch you can work from https://www.drupal.org/node/846290/git-instructions/8.x-1.x/
Create a new issue in the DownloadFile queue and include a patch with your changes and give it a general title like "gngn early contributions to 8.x port".
Include a description of thechanges you've made. In the unlikely event of there being a need to split the changes into multiple issues, I'll take care of it & make sure you're properly credited in each.
I'm excited to see what you've done!
Comment #8
gngn CreditAttribution: gngn at Computer Manufaktur GmbH commentedThank you - I did not find the time to look at it.
But I will!
Comment #9
geek-merlinI did a code review today and from this i'd say it can go beta. I have some ideas to extend it for images and image styles (working on a "download different resolutions" table) and will come back later...!
Comment #10
Chris Matthews CreditAttribution: Chris Matthews commentedPer axel.rutz's comment about a year ago, would it possible to tag a beta release?
Comment #11
geek-merlinGood to come back to this. I have made substantial development extending this for images too, refactoring and cleanup, and as a key project depends on this i will care for the module. See my other modules for references.
So i hereby apply as comaintainer.
My sandbox with the work:
https://www.drupal.org/sandbox/axelrutz/2953882
Comment #12
mmjvb CreditAttribution: mmjvb as a volunteer commentedConsidering the lack of response, suggest to file an issue in the project itself concerning your offer to co-maintain.