# Summary

DownloadFile

# Project URL

https://www.drupal.org/project/download_file

# Where is the code?

https://www.drupal.org/sandbox/bnjmnm/2872204

# Estimated completion date

Mid to Late May 2017

# Dependencies

none

# Who's doing the port?

Bnjmnm

# What help do they need?

Review from a more experienced D8 dev would be great.

# D8 roadmap

No maps needed, just going to get this farily-straightforward module out to yall.

# Background and reference information

I came on as a maintainer for Download File a few months ago to help address an unresolved security issue. It seemed like a good candidate for my first D8 module port.dru

Comments

visabhishek created an issue. See original summary.

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Issue summary: View changes

There is no code...

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm as a volunteer commented

I have a functional (but with currently only one formatter) version in a sandbox. Aiming to have it done in the next week or two.
https://www.drupal.org/sandbox/bnjmnm/2872204

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm as a volunteer commented
Assigned: Unassigned » bnjmnm
Issue summary: View changes
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm as a volunteer commented
Status: Active » Needs work
gngn’s picture

gngn CreditAttribution: gngn at Computer Manufaktur GmbH commented

Hi. thanx for the "headstart" :)
I worked on the module, added some stuff, applied code guidelines etc.
Where can I put my code?
Here? In the issues of the sandbox?
Until now I just added patches...

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm as a volunteer commented

Nice! I created an 8.x dev branch you can work from https://www.drupal.org/node/846290/git-instructions/8.x-1.x/

Create a new issue in the DownloadFile queue and include a patch with your changes and give it a general title like "gngn early contributions to 8.x port".

Include a description of thechanges you've made. In the unlikely event of there being a need to split the changes into multiple issues, I'll take care of it & make sure you're properly credited in each.

I'm excited to see what you've done!

gngn’s picture

gngn CreditAttribution: gngn at Computer Manufaktur GmbH commented

Thank you - I did not find the time to look at it.
But I will!

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin commented

I did a code review today and from this i'd say it can go beta. I have some ideas to extend it for images and image styles (working on a "download different resolutions" table) and will come back later...!

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented

Per axel.rutz's comment about a year ago, would it possible to tag a beta release?

geek-merlin’s picture

geek-merlin
they/omg
Primary language German
Location Freiburg, Germany
CreditAttribution: geek-merlin commented

Good to come back to this. I have made substantial development extending this for images too, refactoring and cleanup, and as a key project depends on this i will care for the module. See my other modules for references.

So i hereby apply as comaintainer.

My sandbox with the work:
https://www.drupal.org/sandbox/axelrutz/2953882

mmjvb’s picture

mmjvb CreditAttribution: mmjvb as a volunteer commented

Considering the lack of response, suggest to file an issue in the project itself concerning your offer to co-maintain.